From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 Received: by atuin.qyliss.net (Postfix, from userid 496) id 223771CE5A; Sun, 8 Aug 2021 17:49:34 +0000 (UTC) Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id C70E11CE45; Sun, 8 Aug 2021 17:49:26 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id E123A1CE30; Sun, 8 Aug 2021 17:49:24 +0000 (UTC) Received: from mail1.systemli.org (mail1.systemli.org [212.103.72.247]) by atuin.qyliss.net (Postfix) with ESMTPS id CD9BE1CE2E for ; Sun, 8 Aug 2021 17:49:22 +0000 (UTC) From: sternenseemann DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=systemli.org; s=default; t=1628444961; bh=wOm7NSWPT6LlUXlMRG1MTD/wUBV406ypt58nOogJL4Q=; h=From:Subject:To:References:Date:In-Reply-To:From; b=2RWi14bMwNYmUwZG/p0o3bOZeHzaAAtBm7YJgPZ2zAyaiWpCEB2p2xPmcfqQdlucr x0rC+9AVTjiRn5dQi+YKlywrQJ7t6oUXHKlwXKuhArWNIwx+Qy9Twl2/30qO3SAiXH YKp4jcXR192mLCnbbVe89T+TDcpmmcTKlL14gxaL7u/AFHAltrrvrtZzd84eNaobm6 8zxxM0BIWQqzOhaaWa5oNyDNDxOOA+Hk9dpwO2NlTwlIlgHRfhMhk+VhbEpssEsqlk qYHbs06G9JkkXW1Kc0aF1YQ8Xc4+VSUmNYtvMJ6NYe5wh6M4+1rvbZp+YcFwzETw2z XTYCRmwcqxLAA== Subject: Re: [PATCH nixpkgs] spectrumPackages: update execline backtick uses To: devel@spectrum-os.org References: <20210808170439.1372425-1-hi@alyssa.is> Message-ID: Date: Sun, 8 Aug 2021 19:49:20 +0200 MIME-Version: 1.0 In-Reply-To: <20210808170439.1372425-1-hi@alyssa.is> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-ID-Hash: I7ODS2I2R6X3KMB7RKPN5MVPWFBXAOXR X-Message-ID-Hash: I7ODS2I2R6X3KMB7RKPN5MVPWFBXAOXR X-MailFrom: sternenseemann@systemli.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.4 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/8/21 7:04 PM, Alyssa Ross wrote: > execline 2.8.0.0 changed how backtick's options work: > > * -i (exit with the program's error code on failure) and -n (chomp off > a trailing newline from the captured output) are now the defaults. > * -E has been introduced, which does importas automatically. > > -E is fantastic, because we followed every single use of backtick with > importas. > > Even we didn't have -n before, it's okay that chomping will now be > enabled from the default, because in all those cases, there won't be a > trailing newline anyway. > --- > .../linux/spectrum/testhost/default.nix | 14 ++++---------- > pkgs/os-specific/linux/spectrum/vm/app/default.nix | 3 +-- > pkgs/os-specific/linux/spectrum/vm/net/default.nix | 6 ++---- > 3 files changed, 7 insertions(+), 16 deletions(-) > > base-commit: d2e147bedf251976ed99b94b6c905d6761f7a892 > -- > 2.32.0 Looks good and quite straightforward. All substitutions seem correct. Reviewed-by: sterni