From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.3 (2019-12-06) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.3 Received: by atuin.qyliss.net (Postfix, from userid 496) id A549218934; Mon, 6 Jul 2020 23:22:45 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 6EEA818964; Mon, 6 Jul 2020 23:22:41 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id E15FD1895F; Mon, 6 Jul 2020 23:22:39 +0000 (UTC) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10olkn2051.outbound.protection.outlook.com [40.92.41.51]) by atuin.qyliss.net (Postfix) with ESMTPS id B823E1895E for ; Mon, 6 Jul 2020 23:22:35 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W0eA8/4nz/wHc3M3DToTJHW/PkZ+JM6OdrRwLm1JaKQUoNDjhrYqFbe2DualQ68qdn9kPUvxjCMC4nlWWjjC/AALuIEOB5sx/fdphu9NTXEmd7C9LJoP4zQOJOh5UY5IyqE+1eDsYj7DqqEpRfrK1B0rlMy8a8qAPbucOq17B7Vx781dx66jdPSMB8LaIeL1dDuCRVMzKgDd7KsSTRBHfd144S+t1pwOUE0mIwEk25ZejlKZ6f/9OJvcLH1nJYDMP8B5I1dSnd5BBE+nHLZ8TA31PwL6hsCBfM+vtl2+EJy7jO//pWTyGkebeDhwr6eDD1F7G7XcdoVaAcQdBSnXLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k+3lSkrF/C9WZR108P11QXgpfLtYIxmcylf3pJeA2mc=; b=Ap4YrMaeSDFHWKFihGqYrdivMa4drxlYvX6D364N8jksuZpcPLuCr1BCl1NwskeuW1XV85emukRPBp1dJ6S6WolepzLr59jK25ap/hN4/UFZ/qgc6uQOhnQlLv3UhAvYgpLTZ0dMvgWAuIJfk78IkBcFfEpjNMX/A5ehxRUubSZnsSljevjN84n2bte2EuSa7Bsh1PZfGL66iN8aJPqKWlX8BmfB/p31UKbs1sYcV6POIs1cvQ+ftkhAYvUTlRUynAadtAPP9elx8Tv+SDIXv6QcS/LCuMSJO9XWI6YFsI58iv0rFVNnSM9jSoYiW+8TdminmsCccmq0K46wBG5pdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k+3lSkrF/C9WZR108P11QXgpfLtYIxmcylf3pJeA2mc=; b=UnFMwRvBSrT58suvjwMa+VENJ1N1/agWg3Ll4dbP3BNn7JcxKkDYEYAegpzv13N07NLpTJOnhJuibDeJPRLrHL/s+9OZVq0egxI/I/cE+EHgVPqluATaGUL/7ow64nPDEXytXQKJfSK9dyNiioD7EBxRZYDVX2fxD9NiSMpNsSrApob+OSbdtshtF38vva/2gkWgfAVtlOQQMxMcSe4Z0wExnHEWSJ/i7fo+0ijn0BrL3lsZ68nUcziJSQqpDwSkQd7/KBbZ300JyeDvvp5kDESj/TTBiiapw4x1zvcnYvpanLoTzG7mC1wphXk0K9Mvl2/ltCRWqTpcSOhvxPRLIQ== Received: from DM6NAM10FT017.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e86::4c) by DM6NAM10HT208.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e86::163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.24; Mon, 6 Jul 2020 23:22:33 +0000 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com (2a01:111:e400:7e86::48) by DM6NAM10FT017.mail.protection.outlook.com (2a01:111:e400:7e86::165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.24 via Frontend Transport; Mon, 6 Jul 2020 23:22:33 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:62AC12AA9CA8695B520C4D0B8BAB8F6CB983DFB8E4254339DA98E4B0C96103A3;UpperCasedChecksum:2DB74C3A10218A1DBC90E2F41FD37D0AE454AFD9D98EC1DEE27E5147C3A9B49D;SizeAsReceived:7411;Count:45 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::61c9:c99c:bd8f:cbd6]) by SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::61c9:c99c:bd8f:cbd6%8]) with mapi id 15.20.3153.029; Mon, 6 Jul 2020 23:22:33 +0000 From: Cole Helbling To: Alyssa Ross , devel@spectrum-os.org Subject: Re: [PATCH crosvm 2/2 v2] sys_util: expand on UnixSeqpacket documentation In-Reply-To: <20200706231401.16999-1-hi@alyssa.is> References: <20200706155913.18065-1-hi@alyssa.is> <20200706231401.16999-1-hi@alyssa.is> Date: Mon, 06 Jul 2020 16:22:31 -0700 Message-ID: Content-Type: text/plain X-ClientProxiedBy: BYAPR07CA0026.namprd07.prod.outlook.com (2603:10b6:a02:bc::39) To SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) X-Microsoft-Original-Message-ID: <87k0zgb554.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (67.187.170.40) by BYAPR07CA0026.namprd07.prod.outlook.com (2603:10b6:a02:bc::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.22 via Frontend Transport; Mon, 6 Jul 2020 23:22:33 +0000 X-Microsoft-Original-Message-ID: <87k0zgb554.fsf@outlook.com> X-TMN: [loQI1AItofyH6SmqAmq3qJIv/ncYC+VC] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 1410b59c-d4da-4441-8da3-08d8220375ed X-MS-TrafficTypeDiagnostic: DM6NAM10HT208: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ylW7xlobERpGMXIldASo+Qz9dFv0hEDfSlDzjyKs/T7kv94k6BUYgbAkItaoCxSXRAIkLyIdzGq2NUCAq/LxlJUQvvkIxPKWc88F7esnTuuoGwEo8TbeQNe7l8rMWAdGpOPQZ2kIZCaDmC+p/zqZQB/IeRcgNL5CDtLUQW9UgwMqoqJ7HP5Lk2gde22m3qvTblQwutdZxesOQFcoNpqvJA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5581.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: PWNjV1ESrg9/9IaJKHu0UhSv5JE3ck/97S26qlAv382HDAQuAowAxjggYtM3spp3XO0jsIFSOUMLxqLkN7LFSsWeO9gHt2c+UXugE01bH8+j8X1bCoRr7Z1+u1kZB4+bVTkPQ+lrZKLSUi03/PUrTQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1410b59c-d4da-4441-8da3-08d8220375ed X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2020 23:22:33.3496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DM6NAM10FT017.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM10HT208 Message-ID-Hash: IJE6MKKSZBTGZDYN5FA7RUVXVEEJ7DUB X-Message-ID-Hash: IJE6MKKSZBTGZDYN5FA7RUVXVEEJ7DUB X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Alyssa Ross writes: > --- > Incorporated Cole's feedback. > > sys_util/src/net.rs | 30 ++++++++++++++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) LGTM, thanks! Reviewed-by: Cole Helbling