From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 1A16C151FD; Wed, 10 Mar 2021 20:51:26 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id C3303151EA; Wed, 10 Mar 2021 20:51:16 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 19034151D5; Wed, 10 Mar 2021 20:51:15 +0000 (UTC) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11olkn2026.outbound.protection.outlook.com [40.92.19.26]) by atuin.qyliss.net (Postfix) with ESMTPS id 9A1C3151D2 for ; Wed, 10 Mar 2021 20:51:11 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D8fV1QYCl96PW6F4xEaRprMrrSe11snkzB0IlLJqOYTlbEDzBaIlq/T8n29mL96WSP1m3L18H0i6VobBMDuglD1zUAF5fh4HOHP+1HPv3wkdqvLLwMC/Hm2sIHqC7GcAyJATCZbdHVK0I89pHfPwbQ3UoFWsQFkQNiFIoGQGQoKZybePpp2fLDaKaBCamX/1PfdVtUvE1lQQOU/Iw7qu3dZZVg8J8g2mKZ4S6b+vIZHuS6RAOmZK0oDZwcw9cuUwFNQwyDYS3o8GYLjvj8GCMw9r6b0YLFFTZ7ywyHo2wlXblNoMSn1lWqhAqHIE2m4+1+eYjgO8QSVs3v7ibXl2Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RkALDFYeFU0jSG8v793xisIxay2vO3qfh+SlB8XgAWs=; b=S3wozLiAvQTk3TjQi9Yzl83VYpa4BzZWAZGV4/yyFmRPMtvd/BDjb230yizVtI/f8Vo+ln5fS8i03B++XI7j/Exep/fGEAReMnCqVAkIlxIFQ8nCP17qMtd8Z+tM3w/I18j1CXaYFQ//rqVGeCa1vkGXjAaVeO0cPU1+olucpb0vuvtw6/x7c7S7eAuHpcJ8nRfLSJYxD3cig3xlax++yfpqFxHtXtZ+msL6yHInVa4QUc4S2tlLQSu7oWJX/eGYz/Gv+3Sm8powkpndZiHjTlcVW8l+PARJfsGyk5ecWsYGO4gGKrt4zQgY3Y3DtA/VctAsTU3xQIvyoufePT0HOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RkALDFYeFU0jSG8v793xisIxay2vO3qfh+SlB8XgAWs=; b=SDF0DJW/DabszzuMvAXJU9E6ARlFifsM2y/YNML9cdgL87VJTCVEGiLQenDU9gxD7WkixXZv8NiWAd1bfsVZfejRF1EeqwN3UDBlJ83R/N1+5+WEtzmnW85zuUYIutl58o6+TKx5oWIM3T7ism4y/2SCSwp1R501tvuaKFxJ2R8YPmJyB6Er74w1kBhXemwkR5HW7JQ0WIkZdzyzptB269emeE5Bv6wZpbq77KkTVO8phcPW1YCvRoy9i14rWtawT5hymLljN8jVlfSCWOSpRY5wKAdOGFLZrchIze18uOAmNLTgFdHUaJGpQKlQcXPxoTASmd9cO5JoENbUZrLk6w== Received: from BN8NAM11FT068.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4b::48) by BN8NAM11HT106.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4b::129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Wed, 10 Mar 2021 20:51:09 +0000 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com (2a01:111:e400:fc4b::42) by BN8NAM11FT068.mail.protection.outlook.com (2a01:111:e400:fc4b::325) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Wed, 10 Mar 2021 20:51:09 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:05D98CBEBE0D89DE209D18B72B7720E34F74F2E8BF624A1BAD9C63DFA2ED228D;UpperCasedChecksum:E53AFCBCE6A8EB53BD9A1994D1743056BC8622D30A9F9E6042B56259008D0C99;SizeAsReceived:8472;Count:44 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94]) by SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94%4]) with mapi id 15.20.3912.030; Wed, 10 Mar 2021 20:51:09 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 To: "Alyssa Ross" , Subject: Re: [PATCH ucspi-vsock] Makefile: link object files instead of source files From: "Cole Helbling" Date: Wed, 10 Mar 2021 12:50:05 -0800 Message-ID: In-Reply-To: <20210310204555.20725-1-hi@alyssa.is> X-TMN: [W6D4evG9tGzbt3mexCl1l8trrKAHpcLx] X-ClientProxiedBy: BYAPR06CA0057.namprd06.prod.outlook.com (2603:10b6:a03:14b::34) To SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (73.48.197.220) by BYAPR06CA0057.namprd06.prod.outlook.com (2603:10b6:a03:14b::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 10 Mar 2021 20:51:08 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 44 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 448dc23b-823d-4552-b320-08d8e4063b44 X-MS-TrafficTypeDiagnostic: BN8NAM11HT106: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ab66E/tez23lMCjfD1q2Yj5rrIfsQRmsLKeq7gnj8MJ8mbLz1dIHIv0HJEz6NWDsMZlJPUKOXDEt6scl5i5Ew1spttNK+Avkj9QoJUkUhw23T1ujV2aAZ5sGRZlokAc4spzFCkzHGmvzrUm8/2cCb30XH0n/Fe3vVpLdfEmnj9yPDAseT70VCL6b5vSIYXwGow0m5hY1S3NofummKzGGkeLdq0JVLAOZx7ePa+3AjZzHjDuvoIdyhwO6GUHjTSCShhOzXTHLL4fM/IkRulLOLZrB3N1eSMlA08qgyhhOer94CUiQFWTso+Sq7gmY8umvpvR70TALUVa92gmwvRPexSLJPsJ2Y0uHQq/SPg6kWDNo6VBspN22RlTnHMn6RfIQ X-MS-Exchange-AntiSpam-MessageData: cuxs58ds40T+bvOLw50cjT7ukNmfBvwKQ2/eVv1CUmHJVqzkSfwh7mMd9D6GYXHjmTlOSHYmiM9LxAWvCm+9uRYpdFdNI2Wh/Kp77JJDO9tjJpiwxzzueIrGw7OEr7f+tIztrKkw01xAqL4abDiV6A== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 448dc23b-823d-4552-b320-08d8e4063b44 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 20:51:08.9932 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM11HT106 Message-ID-Hash: CCU3LI32CUZA5Q34HN4ZQ6TWEKAZASTV X-Message-ID-Hash: CCU3LI32CUZA5Q34HN4ZQ6TWEKAZASTV X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: On Wed Mar 10, 2021 at 12:45 PM PST, Alyssa Ross wrote: > Previously this would (I assume) needlessly recompile vsockserver.c > and vsockclient.c when Make has already automatically compiled those. > > GNU Make has an automatic variable, $+, that we could use here, but > currently the Makefile is portable, and it would be a shame to require > GNU Make just for that. > --- > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index b931c89..4f11b64 100644 > --- a/Makefile > +++ b/Makefile > @@ -19,9 +19,9 @@ install: vsockclient vsockserver > .PHONY: install > =20 > vsockclient: vsockclient.o env.o log.o util.o vsock.o > - $(CC) $(LDFLAGS) -o vsockclient vsockclient.c env.o log.o util.o > vsock.o $(LDLIBS) > + $(CC) $(LDFLAGS) -o vsockclient vsockclient.o env.o log.o util.o > vsock.o $(LDLIBS) > vsockserver: vsockserver.o env.o log.o util.o vsock.o > - $(CC) $(LDFLAGS) -o vsockserver vsockserver.c env.o log.o util.o > vsock.o $(LDLIBS) > + $(CC) $(LDFLAGS) -o vsockserver vsockserver.o env.o log.o util.o > vsock.o $(LDLIBS) > =20 > vsockclient.o: env.h log.h util.h vsock.h > vsockserver.o: env.h log.h util.h vsock.h > -- > 2.30.0 Whee, one character fixes! Reviewed-by: Cole Helbling