* [PATCH ucspi-vsock] Makefile: link object files instead of source files
@ 2021-03-10 20:45 Alyssa Ross
2021-03-10 20:50 ` Cole Helbling
0 siblings, 1 reply; 2+ messages in thread
From: Alyssa Ross @ 2021-03-10 20:45 UTC (permalink / raw)
To: devel
Previously this would (I assume) needlessly recompile vsockserver.c
and vsockclient.c when Make has already automatically compiled those.
GNU Make has an automatic variable, $+, that we could use here, but
currently the Makefile is portable, and it would be a shame to require
GNU Make just for that.
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index b931c89..4f11b64 100644
--- a/Makefile
+++ b/Makefile
@@ -19,9 +19,9 @@ install: vsockclient vsockserver
.PHONY: install
vsockclient: vsockclient.o env.o log.o util.o vsock.o
- $(CC) $(LDFLAGS) -o vsockclient vsockclient.c env.o log.o util.o vsock.o $(LDLIBS)
+ $(CC) $(LDFLAGS) -o vsockclient vsockclient.o env.o log.o util.o vsock.o $(LDLIBS)
vsockserver: vsockserver.o env.o log.o util.o vsock.o
- $(CC) $(LDFLAGS) -o vsockserver vsockserver.c env.o log.o util.o vsock.o $(LDLIBS)
+ $(CC) $(LDFLAGS) -o vsockserver vsockserver.o env.o log.o util.o vsock.o $(LDLIBS)
vsockclient.o: env.h log.h util.h vsock.h
vsockserver.o: env.h log.h util.h vsock.h
--
2.30.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH ucspi-vsock] Makefile: link object files instead of source files
2021-03-10 20:45 [PATCH ucspi-vsock] Makefile: link object files instead of source files Alyssa Ross
@ 2021-03-10 20:50 ` Cole Helbling
0 siblings, 0 replies; 2+ messages in thread
From: Cole Helbling @ 2021-03-10 20:50 UTC (permalink / raw)
To: Alyssa Ross, devel
On Wed Mar 10, 2021 at 12:45 PM PST, Alyssa Ross wrote:
> Previously this would (I assume) needlessly recompile vsockserver.c
> and vsockclient.c when Make has already automatically compiled those.
>
> GNU Make has an automatic variable, $+, that we could use here, but
> currently the Makefile is portable, and it would be a shame to require
> GNU Make just for that.
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b931c89..4f11b64 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -19,9 +19,9 @@ install: vsockclient vsockserver
> .PHONY: install
>
> vsockclient: vsockclient.o env.o log.o util.o vsock.o
> - $(CC) $(LDFLAGS) -o vsockclient vsockclient.c env.o log.o util.o
> vsock.o $(LDLIBS)
> + $(CC) $(LDFLAGS) -o vsockclient vsockclient.o env.o log.o util.o
> vsock.o $(LDLIBS)
> vsockserver: vsockserver.o env.o log.o util.o vsock.o
> - $(CC) $(LDFLAGS) -o vsockserver vsockserver.c env.o log.o util.o
> vsock.o $(LDLIBS)
> + $(CC) $(LDFLAGS) -o vsockserver vsockserver.o env.o log.o util.o
> vsock.o $(LDLIBS)
>
> vsockclient.o: env.h log.h util.h vsock.h
> vsockserver.o: env.h log.h util.h vsock.h
> --
> 2.30.0
Whee, one character fixes!
Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-10 20:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10 20:45 [PATCH ucspi-vsock] Makefile: link object files instead of source files Alyssa Ross
2021-03-10 20:50 ` Cole Helbling
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).