From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 64C0DBD37; Sun, 21 Mar 2021 16:32:15 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 318D9BD21; Sun, 21 Mar 2021 16:32:04 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id E1B5FBCE7; Sun, 21 Mar 2021 16:32:01 +0000 (UTC) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12olkn2108.outbound.protection.outlook.com [40.92.23.108]) by atuin.qyliss.net (Postfix) with ESMTPS id 5239DBCE6 for ; Sun, 21 Mar 2021 16:31:58 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AYn6CLMk4QAbzlcCHr2AV5gO/2QBYMXAk6PG4rkKbLLkjQCgjenpArVsQtZEgYiAynBD3XzfEq+rFbtqNio/uTHaRhg6p7Z/Ro0q8S/j227VyKbnhTArMWW0HS18dDD1SWDusUAwvL1C8PY+8bdGungGTTRiJTbgFNCoEp9axNNk1/311Wswo/S/KYVJ77ZAdJJlcRhumN4hhYCgHbML48qVVXMeEArixbQEQovWC939gItVNip9A3OTeIx4d/EV6TcQGH/jXSCxqB/CWwPhvWAE0p0+L2WeQEOupnt+Gj3aU+KmH+ZT+T5dlDi519ds6zAODpuDgDOAiS92xqUWnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cepyXH7j4iBmrAg3Yibw22v3uV/ZYrZQgM6jFf8bvnc=; b=FxxAtjKqqCUeymMkoNYL4ZwvVY+Z8l560Fp65fM3h3PLBfwfLpz9IANkXKWiAB7CVGwlBh1suUEWgdcdr8Aw1d1dofKQ0SPPRRUA/KmVIl09NwhmSwzD0S1xrLcBhxWXToUrLW64KVts+QmSWnPreQfKYntlY3xIT+FiLDZMokQY1z0/GudMEWYAuOqwD316WYQbxxwp/CKP9fZcM7YN29dbD+cAJRDJqeC2J2BmjJ8oPpInv2LYZD7mh3ltXk4aNGMoNqXW1zYqlck13ZWDLrD3njjQllWWOLhK8KR0dqpOJficIjaYFQptJYNnYlbLjMnyQ3+ydSCskM5OF128bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cepyXH7j4iBmrAg3Yibw22v3uV/ZYrZQgM6jFf8bvnc=; b=Z33g/+k3Y1qIATurImsyWKc8/XgwYH7MHX9y3mgZq+C0kG0N7+zGuOf8QUpp+1xbwNj/6zVfYGBq4NmXVvrhbu00kT3Foc4IpIU+UcWKXp5STHG9xFAFOmiNU4v7cVmvLefjHcehiQ+nStwXUze0qvbBaOZlbk64/eHTjwTdYdC9A880lRNK5a2hPy8tinPTgQqDslwlUUrmqcP7t75YX5a346JglFUpgU/5CDVnqpIZzOHo8kh46DXQTZ6NWPLNbZZSdk9IUQ1x34JwIvvl3tUMrsWuMj9YN+8qMT3YVWb4lxNjT9a9tSoeVHIPyH0M9YP9MCE+DF+q9ZWSfasjSg== Received: from MW2NAM12FT058.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::4f) by MW2NAM12HT041.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.9; Sun, 21 Mar 2021 16:31:55 +0000 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com (2a01:111:e400:fc65::52) by MW2NAM12FT058.mail.protection.outlook.com (2a01:111:e400:fc65::493) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.10 via Frontend Transport; Sun, 21 Mar 2021 16:31:55 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:BE145A8DC6E7BB8F65BFDEB8E38A85F0FFBCCF7A016E1B748BBDEC6DE08EDC59;UpperCasedChecksum:1A354D48349BFF1451CD0C3ED11B9DB01F330DDE185358D5D50A39DCFC6993A3;SizeAsReceived:8503;Count:45 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94]) by SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94%6]) with mapi id 15.20.3955.024; Sun, 21 Mar 2021 16:31:55 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH ucspi-vsock 0/2] Fix clang-tidy warnings From: "Cole Helbling" To: "Alyssa Ross" , Date: Sun, 21 Mar 2021 09:30:42 -0700 Message-ID: In-Reply-To: <20210321144700.24024-1-hi@alyssa.is> X-TMN: [aTze/WSJOOd3+7MiHYkRkeIBqaaVeiIt] X-ClientProxiedBy: BY3PR04CA0030.namprd04.prod.outlook.com (2603:10b6:a03:217::35) To SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (73.48.197.220) by BY3PR04CA0030.namprd04.prod.outlook.com (2603:10b6:a03:217::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Sun, 21 Mar 2021 16:31:55 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 07238cee-b42c-4f8c-7014-08d8ec86d736 X-MS-Exchange-SLBlob-MailProps: wGn/oxjRRS96JvAU8t1iJkQPfZzkbLu/8aZ0eJ2UtPwtKpSt0PhKm8yQE/FHnjECr9Kph6OSRtO3Y0xSy7p84YJD8fR1jz4TurDHQNezflIO5pAJv38JDOM1aKAXtk0NwZChhR9Do9OkgUW/w0fjBv4NOpb1ESESXIDtJGH7mGEw3+hr3OifBbxdmChJgM37iPkbyzDvGM3n+zS/U0D+WV1j2axPcfvCb6m6Ff35mclqUHDWtCjwIW7OH31Z9hAftxW9fA/M8+9qEeKEAJDnJHaLYqTPCldx6AiYTtM0E+vlGl0d7+N+ZItpvqFtH6bRXzwPiyBhkSMxBUVEFnw6ifE9zTQHCbytNAdwFSAGFlqVAt/ntqobL5L8SvJAYccHLdBlLkk4Mn5Clb54cH+dPJXX3UYQiqkHQIgnEmvqgkGRIKjm3i6bjOeA0gz157WgrnSe1F0wEin1GEJnpfCysErg+tgAsA8yQKCiVAgdOoGGfp5Fydzgd6t0t32DA2gg3BQy+e0K2QKVwlQDEWeYQAJ95S/crPpWGJ+6p0k3oYubFe6A4KoFoUdkGwDLtiO6WorgktHkPHMdh7pZxTLsJx42LAR4vOeNogFa4JocdRkuXLuuphbEWOsUG+GuxWE97ASWdj1Tyo3Gtz/s0hV3hvATO5l40SEaKwRLvjNTIFXuWHwbdxDvBvko0vdYYA2NcThnxzkQy8lBEFnWq9xQf+0dIShYPSBUWExgSUYCV6eDXiJIXXB3plHpLrGbRK11HwObPGN2K3WGuxBzor0Z10P3QVienBdJmF9BsmkTJKKHlX1G7AITNFKWPG497kKym1CD1pk7nI6EOMuM/QnZ4z5DEXHwCfSoiY/Nm2IpsJCI4zUGObBmtld04gNUleGR X-MS-TrafficTypeDiagnostic: MW2NAM12HT041: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GH5sRludOoJwd4BD8nLvDEzl1kqxIaZs03Ygwsd2zJglXgVRp/R3oe+gCWMNRdSkNFxK3MBHNUHSXgtT1eXI0ZubWcPGZL8QULnUrUtGw7KbsO9cqky7ZSCd2onJpS1VQZnBNyxLahBTUfnJTddcpceispbsEdi2w9ifuyHZXhzRjqEdloTrPlGVUeumgOqhHyeG8LNvuvlav9TLEAos/24PVNyhq2GCVaMnExMdKb0l/HHavRxEW081DsTnGJ5dtgiEx+oVR1hU/aO97EaeUiDhzu7Toi6BCD0Dw++q3cM8I4E9Rhnb3/nrCyD21k8yWLFtJCgxe32QyeVeozCFHv5qr5CWgldCx5cS1MPdTnhuyLqwJbUvBlIAZcHxPjw8sJ1eIK+XrFIh0G1StJLo7St7MQtSjo1CpSFmcyGjefgmTLfKLTofUUgrMzxTI2kQ X-MS-Exchange-AntiSpam-MessageData: 1CfJ0z3McqEJN8rXGg3XL305EjY4sKa/jJ4iiuOouxnyAweVz/ffXR8b4ajNvNw7r/v4vpq5zDhg79OfwK0e60Ea+p/JZQVQwQytbtXejjj4Ql79P4UUJtBo9LG4NIzrLATVRrfkNamRHbsXrUd7RQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07238cee-b42c-4f8c-7014-08d8ec86d736 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2021 16:31:55.5876 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM12FT058.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM12HT041 Message-ID-Hash: D7422TSPCZXUWIPFA5IX75JLACOA4KGC X-Message-ID-Hash: D7422TSPCZXUWIPFA5IX75JLACOA4KGC X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Cole Helbling X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: On Sun Mar 21, 2021 at 7:46 AM PDT, Alyssa Ross wrote: > clang-tidy also produced this warning: > > /home/src/ucspi-vsock/repro.c:43:19: warning: unused parameter 'sig' = [clang-diagnostic-unused-parameter] > void sig_exit(int sig) { exit(EX_UNAVAILABLE); } > ^ > vsock.c:27:23: warning: The left operand of '!=3D' is a garbage value= [clang-analyzer-core.UndefinedBinaryOperatorResult] > if (addr->svm_family !=3D AF_VSOCK) { > ^ > vsock.c:90:6: note: Assuming the condition is false > if (getsockname(fd, (struct sockaddr *)&addr, &addrlen) =3D= =3D -1) > ^ > vsock.c:90:2: note: Taking false branch > if (getsockname(fd, (struct sockaddr *)&addr, &addrlen) =3D= =3D -1) > ^ > vsock.c:93:9: note: Calling 'fill_cid_and_port' > return fill_cid_and_port(&addr, cid, port); > ^ > vsock.c:27:23: note: The left operand of '!=3D' is a garbage value > if (addr->svm_family !=3D AF_VSOCK) { > > But I think this is just warning me that the POSIX socket API violates > the strict aliasing rule. (Which is true, but there's not a lot I can > do about it...) > > It also tells me I should use memset_s instead of memset, but, well... > https://en.wikipedia.org/wiki/C11_(C_standard_revision)#Criticism > > Alyssa Ross (2): > exec: free argv if exec fails > vsockserver: fix uninitialized variable > > exec.c | 5 ++++- > vsockserver.c | 2 +- > 2 files changed, 5 insertions(+), 2 deletions(-) > > --=20 > 2.30.0 Patchset LGTM. Reviewed-by: Cole Helbling (I should really make a macro or something for that ^, so I don't have to type it out every time and potentially make a mistake :D)