Ville Ilvonen <ville.ilvonen@unikie.com> writes:

> On 8/31/22 12:37, Alyssa Ross wrote:
>> By default, a file called "config.nix" in the root of the Spectrum
>> repository will be read if it exists.  That file should contain an
>> attribute set.  Currently, only a "pkgs" key is supported, which
>> allows specifying a custom package set that will be used throughout
>> the Spectrum Nix files.  This will allow us to provide configuartion
>> options for people who want to build Spectrum in ways that are
>> probably not suitable for upstreaming.
>  >
>> For example, using the "pkgs" config option I'm introducing here, it
>> would be possible to use an overlay to patch individual components,
>> like so:
>>
>>      {
>>        pkgs = import <nixpkgs> {
>>          overlays = [
>>            (final: super: {
>>              weston = super.weston.overrideAttrs ({ patches ? [], ... }: {
>>                patches = patches ++ [
>>                  path/to/weston.patch
>>                ];
>>              });
>>            })
>>          ];
>>        };
>>      }
>>
>> Signed-off-by: Alyssa Ross <hi@alyssa.is>

>> ---
>
> Appreciate it as this makes it more clean to implement device specifics.
> Would you like to see the device specific configs in tree or out of
> tree? One option would be to set the default config and support in tree
> configs of devices people could choose from. Even if not fully supported
> by upstream, they could be useful as examples. If both are possible,
> criteria for guiding in-tree and out-of-tree configs could be also useful.

I'm not sure yet.  Let's maybe revisit once we have generic ARM support
in-tree, and see how it feels then?

> Thanks,
>
> -Ville
>
> Reviewed-by: Ville Ilvonen <ville.ilvonen@unikie.com>

Thanks for the review. :)