From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.3 (2019-12-06) on atuin X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.3 Received: by atuin.qyliss.net (Postfix, from userid 496) id 90479205DB; Thu, 28 May 2020 00:57:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 82E9B205D6; Thu, 28 May 2020 00:57:27 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 3C80D2060F; Thu, 28 May 2020 00:57:25 +0000 (UTC) Received: from sender4-of-o56.zoho.com (sender4-of-o56.zoho.com [136.143.188.56]) by atuin.qyliss.net (Postfix) with ESMTPS id 3D6332060D for ; Thu, 28 May 2020 00:57:22 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1590627436; cv=none; d=zohomail.com; s=zohoarc; b=OldNAl1J7YnGC0KZipV/Q84ClEGVlNV6q2Iu+XPpvT3zdST+Hkec/mC6P/1OBQlLtgJn7WDUHB7UhsJ2PCucCC+CRtMsh4FkJ0HKgNVue87wGcZNYVY1j1Q95MwsDPNDKoE27sm277cD2v6mLbf3ExtnvXCoP5y1i8/hM4P1liE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590627436; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:Message-ID:Subject:To; bh=6nuyUXOfCqtvc0v+6aYSrO5tK6Fxm/20SnT3uquOXko=; b=Ba4W/Qk+zeZNjq36RE+NspGXsy5yCWjXIHZKCFlsykgS66uJTQHzguPD/Pt6ORFVeom8nUxGDMZOXG5TOIz32duUMywYQZ93JC9ZvLIfM2hKM55NG9oN5syfoq3+P8zFnYLZqbnqQVnfuxQRD5L4ZGZKJKhVu0Kgs6oXFP4U7rA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=vendek.net; spf=pass smtp.mailfrom=impaqt@vendek.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1590627436; s=zoho; d=vendek.net; i=impaqt@vendek.net; h=Content-Transfer-Encoding:Content-Type:Subject:From:To:Date:Message-Id:In-Reply-To; bh=6nuyUXOfCqtvc0v+6aYSrO5tK6Fxm/20SnT3uquOXko=; b=U1Lu8Z3MMwiHzsahczgjerifRHQQQ7AF07/mLOzEybt/CpINoDA3z82mx+xPJIAq /Tri4RpHlQCxDav50Qsp0XvvKJnvFHe7IjrFVUzEGKZ1BAkXBeA07rHxj2XHvbWnEZV LQGISt0BdCSRnEKOUkevA/yJAPvjxz6qiLpWKeoc= Received: from localhost (50.35.77.78 [50.35.77.78]) by mx.zohomail.com with SMTPS id 1590627434177666.6458238054358; Wed, 27 May 2020 17:57:14 -0700 (PDT) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH doc v2] Document crosvm memfd server From: "impaqt" To: "Alyssa Ross" , Date: Wed, 27 May 2020 17:40:43 -0700 Message-Id: In-Reply-To: <20200527232709.22211-1-hi@alyssa.is> X-ZohoMailClient: External Message-ID-Hash: RBW2Y4TCPFAEYSRJX3S3H72OG5NGG4GO X-Message-ID-Hash: RBW2Y4TCPFAEYSRJX3S3H72OG5NGG4GO X-MailFrom: impaqt@vendek.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.3.0 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Looks good. One minor nitpick, take it or leave it: > +Spectrum's crosvm has been augmented with a feature called the "`memfd > +server`", (currently only on the > +https://spectrum-os.org/git/crosvm/log/?h=3Dinterguest[interguest] > +branch). This is a small server that listens on a Unix stream socket. This should be either a comma or parenthesis, not both. This is just a personal preference of mine, but one I wish were more widely adopted: when writing markdown I only wrap the "proper nouns" in `code blocks` for consistency, e.g. "`memfd` server" not "`memfd server`". But this isn't a hill I'm prepared to die on. Reviewed-by: impaqt ^^^ Is this what you meant by a tag?