* [PATCH ucspi-vsock] Makefile: stop repeating program list
@ 2021-03-18 0:36 Alyssa Ross
2021-03-18 6:57 ` Cole Helbling
0 siblings, 1 reply; 5+ messages in thread
From: Alyssa Ross @ 2021-03-18 0:36 UTC (permalink / raw)
To: devel
Using a wildcard with rm -f means that if there are no object files to
remove, rm will try to remove a non-existent file named '*.c', and
then ignore the failure it gets by trying to do that. Which is fine.
---
Makefile | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Makefile b/Makefile
index 1a4bb10..2045cdd 100644
--- a/Makefile
+++ b/Makefile
@@ -10,12 +10,14 @@ INSTALL_PROGRAM = $(INSTALL)
prefix = /usr/local
bindir = $(prefix)/bin
-all: vsockclient vsockserver
+PROGRAMS = vsockclient vsockserver
+
+all: $(PROGRAMS)
.PHONY: all
-install: vsockclient vsockserver
+install: $(PROGRAMS)
mkdir -p $(DESTDIR)$(bindir)
- $(INSTALL_PROGRAM) vsockclient vsockserver $(DESTDIR)$(bindir)
+ $(INSTALL_PROGRAM) $(PROGRAMS) $(DESTDIR)$(bindir)
.PHONY: install
vsockclient: vsockclient.o env.o log.o num.o vsock.o
@@ -27,6 +29,5 @@ vsockclient.o: env.h log.h num.h vsock.h
vsockserver.o: env.h log.h num.h vsock.h
clean:
- rm -f env.o log.o num.o vsock.o \
- vsockclient.o vsockclient vsockserver.o vsockserver
+ rm -f $(PROGRAMS) *.o
.PHONY: clean
--
2.30.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH ucspi-vsock] Makefile: stop repeating program list
2021-03-18 0:36 [PATCH ucspi-vsock] Makefile: stop repeating program list Alyssa Ross
@ 2021-03-18 6:57 ` Cole Helbling
2021-03-18 12:57 ` Alyssa Ross
0 siblings, 1 reply; 5+ messages in thread
From: Cole Helbling @ 2021-03-18 6:57 UTC (permalink / raw)
To: Alyssa Ross, devel
On Wed Mar 17, 2021 at 5:36 PM PDT, Alyssa Ross wrote:
> Using a wildcard with rm -f means that if there are no object files to
> remove, rm will try to remove a non-existent file named '*.c', and
Nit: do you mean '*.o'? ;)
> then ignore the failure it gets by trying to do that. Which is fine.
> ---
> Makefile | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH ucspi-vsock] Makefile: stop repeating program list
2021-03-18 6:57 ` Cole Helbling
@ 2021-03-18 12:57 ` Alyssa Ross
2021-03-18 16:30 ` Cole Helbling
0 siblings, 1 reply; 5+ messages in thread
From: Alyssa Ross @ 2021-03-18 12:57 UTC (permalink / raw)
To: Cole Helbling; +Cc: devel
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
>> Using a wildcard with rm -f means that if there are no object files to
>> remove, rm will try to remove a non-existent file named '*.c', and
>
> Nit: do you mean '*.o'? ;)
Oh, yes I do. I'll just fix that up locally without sending a new patch.
>> then ignore the failure it gets by trying to do that. Which is fine.
>> ---
>> Makefile | 11 ++++++-----
>> 1 file changed, 6 insertions(+), 5 deletions(-)
Look good otherwise? :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH ucspi-vsock] Makefile: stop repeating program list
2021-03-18 12:57 ` Alyssa Ross
@ 2021-03-18 16:30 ` Cole Helbling
2021-03-18 19:06 ` Alyssa Ross
0 siblings, 1 reply; 5+ messages in thread
From: Cole Helbling @ 2021-03-18 16:30 UTC (permalink / raw)
To: Alyssa Ross; +Cc: devel
On Thu Mar 18, 2021 at 5:57 AM PDT, Alyssa Ross wrote:
> >> Using a wildcard with rm -f means that if there are no object files to
> >> remove, rm will try to remove a non-existent file named '*.c', and
> >
> > Nit: do you mean '*.o'? ;)
>
> Oh, yes I do. I'll just fix that up locally without sending a new patch.
>
> >> then ignore the failure it gets by trying to do that. Which is fine.
> >> ---
> >> Makefile | 11 ++++++-----
> >> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> Look good otherwise? :)
Yes indeed!
Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH ucspi-vsock] Makefile: stop repeating program list
2021-03-18 16:30 ` Cole Helbling
@ 2021-03-18 19:06 ` Alyssa Ross
0 siblings, 0 replies; 5+ messages in thread
From: Alyssa Ross @ 2021-03-18 19:06 UTC (permalink / raw)
To: Cole Helbling; +Cc: devel
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
>> >> Using a wildcard with rm -f means that if there are no object files to
>> >> remove, rm will try to remove a non-existent file named '*.c', and
>> >
>> > Nit: do you mean '*.o'? ;)
>>
>> Oh, yes I do. I'll just fix that up locally without sending a new patch.
>>
>> >> then ignore the failure it gets by trying to do that. Which is fine.
>> >> ---
>> >> Makefile | 11 ++++++-----
>> >> 1 file changed, 6 insertions(+), 5 deletions(-)
>>
>> Look good otherwise? :)
>
> Yes indeed!
>
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
Thanks! Committed as f55c634.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-18 19:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 0:36 [PATCH ucspi-vsock] Makefile: stop repeating program list Alyssa Ross
2021-03-18 6:57 ` Cole Helbling
2021-03-18 12:57 ` Alyssa Ross
2021-03-18 16:30 ` Cole Helbling
2021-03-18 19:06 ` Alyssa Ross
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).