patches and low-level development discussion
 help / color / mirror / code / Atom feed
* [PATCH ucspi-vsock] Remove unused includes
@ 2021-03-24 13:50 Alyssa Ross
  2021-03-24 18:43 ` Cole Helbling
  0 siblings, 1 reply; 3+ messages in thread
From: Alyssa Ross @ 2021-03-24 13:50 UTC (permalink / raw)
  To: devel

---
 vsock.c       | 1 -
 vsockclient.c | 3 ---
 2 files changed, 4 deletions(-)

diff --git a/vsock.c b/vsock.c
index ab8c4bd..159a51f 100644
--- a/vsock.c
+++ b/vsock.c
@@ -6,7 +6,6 @@
 #include "vsock.h"
 
 #include <errno.h>
-#include <sys/ioctl.h>
 #include <sys/socket.h>
 
 #include <linux/vm_sockets.h>
diff --git a/vsockclient.c b/vsockclient.c
index d6cc778..934cfa0 100644
--- a/vsockclient.c
+++ b/vsockclient.c
@@ -8,12 +8,9 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <stdnoreturn.h>
-#include <sys/socket.h>
 #include <sysexits.h>
 #include <unistd.h>
 
-#include <linux/vm_sockets.h>
-
 #include "env.h"
 #include "log.h"
 #include "num.h"
-- 
2.30.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH ucspi-vsock] Remove unused includes
  2021-03-24 13:50 [PATCH ucspi-vsock] Remove unused includes Alyssa Ross
@ 2021-03-24 18:43 ` Cole Helbling
  2021-03-24 19:53   ` Alyssa Ross
  0 siblings, 1 reply; 3+ messages in thread
From: Cole Helbling @ 2021-03-24 18:43 UTC (permalink / raw)
  To: Alyssa Ross, devel

On Wed Mar 24, 2021 at 6:50 AM PDT, Alyssa Ross wrote:
> ---
>  vsock.c       | 1 -
>  vsockclient.c | 3 ---
>  2 files changed, 4 deletions(-)

Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH ucspi-vsock] Remove unused includes
  2021-03-24 18:43 ` Cole Helbling
@ 2021-03-24 19:53   ` Alyssa Ross
  0 siblings, 0 replies; 3+ messages in thread
From: Alyssa Ross @ 2021-03-24 19:53 UTC (permalink / raw)
  To: Cole Helbling; +Cc: devel

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

> On Wed Mar 24, 2021 at 6:50 AM PDT, Alyssa Ross wrote:
>> ---
>>  vsock.c       | 1 -
>>  vsockclient.c | 3 ---
>>  2 files changed, 4 deletions(-)
>
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>

Committed as d24ff2d.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-24 19:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 13:50 [PATCH ucspi-vsock] Remove unused includes Alyssa Ross
2021-03-24 18:43 ` Cole Helbling
2021-03-24 19:53   ` Alyssa Ross

Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).