From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id B5BE360FE7; Tue, 20 Sep 2022 11:32:16 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 1970761088; Tue, 20 Sep 2022 11:32:14 +0000 (UTC) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by atuin.qyliss.net (Postfix) with ESMTPS id 554D661086 for ; Tue, 20 Sep 2022 11:32:10 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id EA08C5C0089; Tue, 20 Sep 2022 07:32:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 20 Sep 2022 07:32:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663673528; x=1663759928; bh=O+poKnQC3H McJ37ywTWHdAbb1chZ5ldpW0scU/kc1Uw=; b=Fm4De+Cu8P5amlMoGLC3QnASx+ 8EZ9MarhugBL5ZgN9gogX23e7PivxGMlmK5l58F1CeEgIEAR5K9gG/ISQRcu4R9F y+ywOEtundE1hVbU8tlda1/y4nL3r5BCW3do9hDMNLbliDN+hIJLgxMOa4r+akBT RIRJ8WERXu4/j99Hqsehv4KbY1NFq5nQ6WN3GlKfLXDoUU7l0VNtKaa8VK8dNNhy d86BSzZYZrpzP/uWvRxECiELFPU9L8r35WA6D0U3GZl4W6XtyZaH9lmA7ujocpW6 6C9J3HNQLGOYks07RA8i5of1zg/H1KgnU5n15ZAHZqDbvS+VGPOCrAZzmNfw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663673528; x=1663759928; bh=O+poKnQC3HMcJ37ywTWHdAbb1chZ 5ldpW0scU/kc1Uw=; b=eAEfIrW0MoDzBcYAJDVvNd6hub1V1sdZryMExHj+vXOm g68LJYu7tC6OlvDtv2IPENuOWqbB1GHFV6Ar/9aJ2X7tlOT5kQOBKSBPn1n3TXPs wmZW1CoAP0aUHLGlVj++f/seKGRSgaQ/gFvfBDz2H43w87di9UBUuJLJwVxvo5IM sso2bhFsBST4W2HrY40A6sSaTHVzpogRJdljqpJZLFRD2Kb+/NuE50MEdoWSoDRU xa3lqMKtKZJFNm3I05h5pOh89KhIHtQXNz6XUs+mM8zXLkiPYiAOhlarF4wtc+/T OPsu8SUH68CqPbHecZelHZqYRFypVk7g+rgGOsdjGg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvledggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkgggtsehgtderredttdejnecuhfhrohhmpeetlhihshhs rgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeethe evudfgjefghefhieejudelkeeljeegvdekueeuhffhgedvveefteevgeetieenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihssh grrdhish X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Sep 2022 07:32:08 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 3CE6E9943; Tue, 20 Sep 2022 11:32:06 +0000 (UTC) From: Alyssa Ross To: Ville Ilvonen Subject: Re: [PATCH] fix: config support with vms In-Reply-To: <20220920110958.2548848-1-ville.ilvonen@unikie.com> References: <20220920110958.2548848-1-ville.ilvonen@unikie.com> Date: Tue, 20 Sep 2022 11:31:40 +0000 Message-ID: <87fsgmmgdf.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: TSFZO46ZDGHXEJ4A2XUGGXEA6X4Z3K6W X-Message-ID-Hash: TSFZO46ZDGHXEJ4A2XUGGXEA6X4Z3K6W X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ville Ilvonen writes: > with config.nix, the build of vms fails with > error: undefined variable 'pkgs' > .. > 49| > 50| kernel =3D pkgs.linux_latest.override { > | ^ > > This fixes the issue for all default vms > > Signed-off-by: Ville Ilvonen > --- Hi Ville, I was wondering how I'd have missed something like the default VMs not evaluating, but indeed I'm not able to reproduce this. And when I look at the default.nix files for the default VMs, I see: 50 kernel =3D buildPackages.linux.override { So unless I've missed something, I don't think this issue exists in the current upstream. (I checked commit 3aa2f8a.) Although this does make me wonder /why/ buildPackages is used here =E2=80=94 I think that would be incorrect in the case of cross compilation. Possibly it was just a hack I used to work around some pkgsStatic issue with the kernel at the time, and then forgot to change back. The right thing to do here would be for linux_latest to be an argument to the function passed to callPackage. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmMppJ4ACgkQ+dvtSFmy ccD/whAAiPuY7hI3j5n0QyNKjClcGVbOGDibAEC/qQa7owfKuCQtxVgjUvf2iVv6 +h4mZ3ysOMNs4se/YQPpbvLyAZFWOP1zr67MiPFJ72fIy0VFH4emsWLrl9rxcQW5 9pZ8bujZR3m/RkyIl167tdKV5Fkrv1JHpBzkCtce6vsL2s0BPGM/GHuP2sqfsdvB lY1VJFKLBqJcEgOGdk8h1kf/tqkYkdNDOWSbQgwinbEcCQtkbzWWH1hkzKw0f6Uy 06RKt/ecJpmLDcZ2pHLOnEHIMJfAtBbw17NsbfRMxjUXbiuUYlf5zVjzK5UrdahY FwTFOaSz83rL9tylJuVBcvgDRhWf/msPUP1Juy1RwXBS2xyN+lBWrwHXl4KCtJuN 0f66CBmgnysna7QLYql3+zMkO22vrto7iWngqhC7fcg9RVYsHfC/CVQZgRFQeNWI X59ahhDxfR5i5WBJqUaCbYda/5ET9V2CChSS3qaa63I5tz4YWtua/MCHpnranP6g siCNaa17qPhAjDlhmycxUmpI16mEtJXxEMcOUrND2vQa5y2POdeJ1a5Qt06IZjqh MhdEp1kfg7bLSHF1DHO2QvXmhhaSzbBdELZYhtBJd3pnwi/f3GtqibJbpbsSmpCz lBR6GNCKgtLlXYoaRr+693X2OO4dggK+01CZCbkVDPmutHRG360= =4E8t -----END PGP SIGNATURE----- --=-=-=--