patches and low-level development discussion
 help / color / mirror / Atom feed
* [PATCH] start-vm: Remove rngd (unecessary since the introduction of khwrngd)
@ 2019-12-29 17:09 Nicolas Braud-Santoni
  2019-12-29 17:46 ` Alyssa Ross
  0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Braud-Santoni @ 2019-12-29 17:09 UTC (permalink / raw)
  To: devel

khwrngd provides the same functionality as rngd here, but is integrated in the
kernel, and started by default by the hwrng driver as soon as the device is
initialized.

It was added in Linux 3.17 by the following commit:

commit be4000bc4644d027c519b6361f5ae3bbfc52c347
Author: Torsten Duwe <duwe@lst.de>
Date:   Sat Jun 14 23:46:03 2014 -0400

    hwrng: create filler thread

    This can be viewed as the in-kernel equivalent of hwrngd;
    like FUSE it is a good thing to have a mechanism in user land,
    but for some reasons (simplicity, secrecy, integrity, speed)
    it may be better to have it in kernel space.

    This patch creates a thread once a hwrng registers, and uses
    the previously established add_hwgenerator_randomness() to feed
    its data to the input pool as long as needed. A derating factor
    is used to bias the entropy estimation and to disable this
    mechanism entirely when set to zero.
---
 start-vm.nix | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/start-vm.nix b/start-vm.nix
index 442f83a8f45..66fb358cb39 100644
--- a/start-vm.nix
+++ b/start-vm.nix
@@ -45,14 +45,6 @@ let
             s6-linux-init-hpr -fr
           '';
         } // services.".s6-svscan" or {};
-
-        rngd = {
-          run = writeScript "rngd-run" ''
-            #! ${execline}/bin/execlineb -P
-            ${rng-tools}/bin/rngd -f -x pkcs11,rdrand
-          '';
-        } // services.rngd or {};
-
       } // services;
 
     in
-- 
2.24.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] start-vm: Remove rngd (unecessary since the introduction of khwrngd)
  2019-12-29 17:09 [PATCH] start-vm: Remove rngd (unecessary since the introduction of khwrngd) Nicolas Braud-Santoni
@ 2019-12-29 17:46 ` Alyssa Ross
  0 siblings, 0 replies; 2+ messages in thread
From: Alyssa Ross @ 2019-12-29 17:46 UTC (permalink / raw)
  To: Nicolas Braud-Santoni; +Cc: devel

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

> khwrngd provides the same functionality as rngd here, but is integrated in the
> kernel, and started by default by the hwrng driver as soon as the device is
> initialized.

Thank you!

To ssh://spectrum-os.org/home/spectrum/git/nixpkgs.git
   b4c9b8e4499..d02ab4cfbb6  crosvm-demo -> crosvm-demo

I wish I could remember what documentation I read that said I needed
rngd so we could update it.  I thought it was somewhere in either the
kernel or crosvm, but looking through both now I don't see it.  Oh well.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-29 17:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-29 17:09 [PATCH] start-vm: Remove rngd (unecessary since the introduction of khwrngd) Nicolas Braud-Santoni
2019-12-29 17:46 ` Alyssa Ross

patches and low-level development discussion

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://spectrum-os.org/lists/archives/spectrum-devel/0 spectrum-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 spectrum-devel spectrum-devel/ https://spectrum-os.org/lists/archives/spectrum-devel \
		public-inbox+spectrum-devel@spectrum-os.org devel@spectrum-os.org
	public-inbox-index spectrum-devel

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntps://spectrum-os.org/inbox.comp.spectrum.devel
	nntp://spectrum-os.org/inbox.comp.spectrum.devel


code repositories for the project(s) associated with this inbox:

	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

AGPL code for this site: https://ftp.qyliss.net/public-inbox/public-inbox-1.6.1-qyliss-zrbwij2k44al87hjcxw5j4jj8nd4aqgm.tar.gz