* [PATCH] img/live: add rootfs attribute passthru
@ 2022-09-22 14:47 Yuri Nesterov
2022-09-23 7:51 ` Ville Ilvonen
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Yuri Nesterov @ 2022-09-22 14:47 UTC (permalink / raw)
To: devel; +Cc: Yuri Nesterov
This allows to get access to rootfs and kernel from device images.
Signed-off-by: Yuri Nesterov <yuriy.nesterov@unikie.com>
---
img/live/default.nix | 2 ++
1 file changed, 2 insertions(+)
diff --git a/img/live/default.nix b/img/live/default.nix
index 65ad058..5461384 100644
--- a/img/live/default.nix
+++ b/img/live/default.nix
@@ -45,4 +45,6 @@ stdenvNoCC.mkDerivation {
'';
enableParallelBuilding = true;
+
+ passthru = { inherit rootfs; };
}
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] img/live: add rootfs attribute passthru
2022-09-22 14:47 [PATCH] img/live: add rootfs attribute passthru Yuri Nesterov
@ 2022-09-23 7:51 ` Ville Ilvonen
2022-09-23 10:10 ` Ivan Nikolaenko
2022-09-23 12:16 ` Alyssa Ross
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Ville Ilvonen @ 2022-09-23 7:51 UTC (permalink / raw)
To: Yuri Nesterov, devel
On 9/22/22 17:47, Yuri Nesterov wrote:
> This allows to get access to rootfs and kernel from device images.
>
> Signed-off-by: Yuri Nesterov <yuriy.nesterov@unikie.com>
> ---
> img/live/default.nix | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/img/live/default.nix b/img/live/default.nix
> index 65ad058..5461384 100644
> --- a/img/live/default.nix
> +++ b/img/live/default.nix
> @@ -45,4 +45,6 @@ stdenvNoCC.mkDerivation {
> '';
>
> enableParallelBuilding = true;
> +
> + passthru = { inherit rootfs; };
> }
Thanks, fixes the issue and takes us to the next issue before
out-of-tree build reference configs with imx8 variants are supported.
~/out-of-tree-build
❯ nix-build spectrum-config-imx8/imx8qxp/ -I nixpkgs=nixpkgs-spectrum/
this derivation will be built:
/nix/store/0xgldphzh2kjgckd13k3azarzvkdqqvs-spectrum-live-imx8qxp.img-0.1.drv
building
'/nix/store/0xgldphzh2kjgckd13k3azarzvkdqqvs-spectrum-live-imx8qxp.img-0.1.drv'...
/nix/store/nlzy51mvniqk080jlszm37j0hzi6m9rv-stdenv-linux/setup: line
1340: spectrum: command not found
Tested-by: Ville Ilvonen <ville.ilvonen@unikie.com>
-Ville
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] img/live: add rootfs attribute passthru
2022-09-23 7:51 ` Ville Ilvonen
@ 2022-09-23 10:10 ` Ivan Nikolaenko
2022-09-23 12:26 ` Ville Ilvonen
0 siblings, 1 reply; 8+ messages in thread
From: Ivan Nikolaenko @ 2022-09-23 10:10 UTC (permalink / raw)
To: Ville Ilvonen, Yuri Nesterov, devel
Hello,
There is a typo in imx8qxp config file:
diff --git a/imx8qxp/default.nix b/imx8qxp/default.nix
index 096d6aa..dc1d41f 100644
--- a/imx8qxp/default.nix
+++ b/imx8qxp/default.nix
@@ -24,7 +24,7 @@ stdenvNoCC.mkDerivation {
];
buildCommand = ''
- install -m 0644 $(spectrum) spectrum-live-imx8qxp.img
+ install -m 0644 ${spectrum} spectrum-live-imx8qxp.img
dd if=${uboot}/flash.bin of=spectrum-live-imx8qxp.img bs=1k
seek=32 conv=notrunc
IMG=spectrum-live-imx8qxp.img
ESP_OFFSET=$(sfdisk --json $IMG | jq -r '
Fixing this allows to proceed to the next error:
make: *** No rule to make target '.......systemd-bootx64.efi', needed by
'build/boot.fat'. Stop.
But this one is pretty straightforward.
Ivan
On 9/23/22 10:51, Ville Ilvonen wrote:
> On 9/22/22 17:47, Yuri Nesterov wrote:
>> This allows to get access to rootfs and kernel from device images.
>>
>> Signed-off-by: Yuri Nesterov <yuriy.nesterov@unikie.com>
>> ---
>> img/live/default.nix | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/img/live/default.nix b/img/live/default.nix
>> index 65ad058..5461384 100644
>> --- a/img/live/default.nix
>> +++ b/img/live/default.nix
>> @@ -45,4 +45,6 @@ stdenvNoCC.mkDerivation {
>> '';
>> enableParallelBuilding = true;
>> +
>> + passthru = { inherit rootfs; };
>> }
>
> Thanks, fixes the issue and takes us to the next issue before
> out-of-tree build reference configs with imx8 variants are supported.
>
> ~/out-of-tree-build
> ❯ nix-build spectrum-config-imx8/imx8qxp/ -I nixpkgs=nixpkgs-spectrum/
> this derivation will be built:
>
> /nix/store/0xgldphzh2kjgckd13k3azarzvkdqqvs-spectrum-live-imx8qxp.img-0.1.drv
>
> building
> '/nix/store/0xgldphzh2kjgckd13k3azarzvkdqqvs-spectrum-live-imx8qxp.img-0.1.drv'...
> /nix/store/nlzy51mvniqk080jlszm37j0hzi6m9rv-stdenv-linux/setup: line
> 1340: spectrum: command not found
>
> Tested-by: Ville Ilvonen <ville.ilvonen@unikie.com>
>
> -Ville
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] img/live: add rootfs attribute passthru
2022-09-22 14:47 [PATCH] img/live: add rootfs attribute passthru Yuri Nesterov
2022-09-23 7:51 ` Ville Ilvonen
@ 2022-09-23 12:16 ` Alyssa Ross
2022-09-23 12:20 ` Alyssa Ross
2022-09-23 12:21 ` Alyssa Ross
3 siblings, 0 replies; 8+ messages in thread
From: Alyssa Ross @ 2022-09-23 12:16 UTC (permalink / raw)
To: Yuri Nesterov, devel; +Cc: Yuri Nesterov
This patch has been committed as e0e912a70f6c3307f58b843df0813ebf1c2940bc,
which can be viewed online at
https://spectrum-os.org/git/spectrum/commit/?id=e0e912a70f6c3307f58b843df0813ebf1c2940bc.
This is an automated message. Send comments/questions/requests to:
Alyssa Ross <hi@alyssa.is>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] img/live: add rootfs attribute passthru
2022-09-22 14:47 [PATCH] img/live: add rootfs attribute passthru Yuri Nesterov
2022-09-23 7:51 ` Ville Ilvonen
2022-09-23 12:16 ` Alyssa Ross
@ 2022-09-23 12:20 ` Alyssa Ross
2022-09-23 12:21 ` Alyssa Ross
3 siblings, 0 replies; 8+ messages in thread
From: Alyssa Ross @ 2022-09-23 12:20 UTC (permalink / raw)
To: Yuri Nesterov, devel; +Cc: Yuri Nesterov
This patch has been committed as c40097fe9aa371b998506b199466d9f0a7cdfa21,
which can be viewed online at
https://spectrum-os.org/git/spectrum/commit/?id=c40097fe9aa371b998506b199466d9f0a7cdfa21.
This is an automated message. Send comments/questions/requests to:
Alyssa Ross <hi@alyssa.is>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] img/live: add rootfs attribute passthru
2022-09-22 14:47 [PATCH] img/live: add rootfs attribute passthru Yuri Nesterov
` (2 preceding siblings ...)
2022-09-23 12:20 ` Alyssa Ross
@ 2022-09-23 12:21 ` Alyssa Ross
2022-09-23 12:33 ` Alyssa Ross
3 siblings, 1 reply; 8+ messages in thread
From: Alyssa Ross @ 2022-09-23 12:21 UTC (permalink / raw)
To: Yuri Nesterov, devel; +Cc: Yuri Nesterov
This patch has been committed as 0ca216d4ff06caa2ff6416e247c68f1e968d14d4,
which can be viewed online at
https://spectrum-os.org/git/spectrum/commit/?id=0ca216d4ff06caa2ff6416e247c68f1e968d14d4.
This is an automated message. Send comments/questions/requests to:
Alyssa Ross <hi@alyssa.is>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] img/live: add rootfs attribute passthru
2022-09-23 10:10 ` Ivan Nikolaenko
@ 2022-09-23 12:26 ` Ville Ilvonen
0 siblings, 0 replies; 8+ messages in thread
From: Ville Ilvonen @ 2022-09-23 12:26 UTC (permalink / raw)
To: Ivan Nikolaenko, Yuri Nesterov, devel
On 9/23/22 13:10, Ivan Nikolaenko wrote:
> Hello,
> There is a typo in imx8qxp config file:
Thanks Ivan, I noticed it in the morning and fixed it in the
out-of-spectrum-tree config at
https://github.com/tiiuae/spectrum-config-imx8/blob/main/imx8qxp/default.nix#L27
-Ville
> diff --git a/imx8qxp/default.nix b/imx8qxp/default.nix
> index 096d6aa..dc1d41f 100644
> --- a/imx8qxp/default.nix
> +++ b/imx8qxp/default.nix
> @@ -24,7 +24,7 @@ stdenvNoCC.mkDerivation {
> ];
>
> buildCommand = ''
> - install -m 0644 $(spectrum) spectrum-live-imx8qxp.img
> + install -m 0644 ${spectrum} spectrum-live-imx8qxp.img
> dd if=${uboot}/flash.bin of=spectrum-live-imx8qxp.img bs=1k
> seek=32 conv=notrunc
> IMG=spectrum-live-imx8qxp.img
> ESP_OFFSET=$(sfdisk --json $IMG | jq -r '
>
> Fixing this allows to proceed to the next error:
> make: *** No rule to make target '.......systemd-bootx64.efi', needed by
> 'build/boot.fat'. Stop.
> But this one is pretty straightforward.
>
> Ivan
>
> On 9/23/22 10:51, Ville Ilvonen wrote:
>> On 9/22/22 17:47, Yuri Nesterov wrote:
>>> This allows to get access to rootfs and kernel from device images.
>>>
>>> Signed-off-by: Yuri Nesterov <yuriy.nesterov@unikie.com>
>>> ---
>>> img/live/default.nix | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/img/live/default.nix b/img/live/default.nix
>>> index 65ad058..5461384 100644
>>> --- a/img/live/default.nix
>>> +++ b/img/live/default.nix
>>> @@ -45,4 +45,6 @@ stdenvNoCC.mkDerivation {
>>> '';
>>> enableParallelBuilding = true;
>>> +
>>> + passthru = { inherit rootfs; };
>>> }
>>
>> Thanks, fixes the issue and takes us to the next issue before
>> out-of-tree build reference configs with imx8 variants are supported.
>>
>> ~/out-of-tree-build
>> ❯ nix-build spectrum-config-imx8/imx8qxp/ -I nixpkgs=nixpkgs-spectrum/
>> this derivation will be built:
>>
>> /nix/store/0xgldphzh2kjgckd13k3azarzvkdqqvs-spectrum-live-imx8qxp.img-0.1.drv
>> building
>> '/nix/store/0xgldphzh2kjgckd13k3azarzvkdqqvs-spectrum-live-imx8qxp.img-0.1.drv'...
>> /nix/store/nlzy51mvniqk080jlszm37j0hzi6m9rv-stdenv-linux/setup: line
>> 1340: spectrum: command not found
>>
>> Tested-by: Ville Ilvonen <ville.ilvonen@unikie.com>
>>
>> -Ville
>>
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] img/live: add rootfs attribute passthru
2022-09-23 12:21 ` Alyssa Ross
@ 2022-09-23 12:33 ` Alyssa Ross
0 siblings, 0 replies; 8+ messages in thread
From: Alyssa Ross @ 2022-09-23 12:33 UTC (permalink / raw)
To: devel; +Cc: Yuri Nesterov
[-- Attachment #1: Type: text/plain, Size: 990 bytes --]
Alyssa Ross <qyliss@atuin.qyliss.net> writes:
> This patch has been committed as 0ca216d4ff06caa2ff6416e247c68f1e968d14d4,
> which can be viewed online at
> https://spectrum-os.org/git/spectrum/commit/?id=0ca216d4ff06caa2ff6416e247c68f1e968d14d4.
>
> This is an automated message. Send comments/questions/requests to:
> Alyssa Ross <hi@alyssa.is>
Just to explain what happened here for transparency: I noticed that I'd
accidentally dropped Yuri's authorship information from the commit, so I
did a quick force push to restore it.
(I know force pushes can be disruptive — I would not have done this if I
hadn't noticed /immediately/ after publishing. And the commit
notification bot does a nice job of making it clear and transparent what
happened — it might be nice to extend that to something that sent an
email every time a push happened, not just when a patch was taken from
devel@. Maybe to a separate list to avoid spamming people who're not
interested.)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-09-23 12:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-22 14:47 [PATCH] img/live: add rootfs attribute passthru Yuri Nesterov
2022-09-23 7:51 ` Ville Ilvonen
2022-09-23 10:10 ` Ivan Nikolaenko
2022-09-23 12:26 ` Ville Ilvonen
2022-09-23 12:16 ` Alyssa Ross
2022-09-23 12:20 ` Alyssa Ross
2022-09-23 12:21 ` Alyssa Ross
2022-09-23 12:33 ` Alyssa Ross
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).