From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.3 (2019-12-06) on atuin X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.3 Received: by atuin.qyliss.net (Postfix, from userid 496) id 9BEBB21EA7; Fri, 29 May 2020 18:12:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id E717521DF3; Fri, 29 May 2020 18:12:32 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id F0E5621E8F; Fri, 29 May 2020 18:12:29 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by atuin.qyliss.net (Postfix) with ESMTPS id 3C4DB21DED for ; Fri, 29 May 2020 18:12:27 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id F17185C0085; Fri, 29 May 2020 14:12:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 29 May 2020 14:12:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=QqAGjQy2Rv7S0crK1cGgBQzFGj yD3XT+R+oYDMxmbKM=; b=G9ehw96/I4do6RTADg4bX9Fy0c0gMr65wZW0zZLIyK 1Afqz/QJU+LKDNAbdlln38x43UlUYZo8dfLSs5aUVnQwFj9Y0UJDUmPG0qOjFKhm 35/9miY9U8Lc5Q9hoNFTnLofXEu9bzdb2AqG8wLPCPMaVLosAE/qJmJZqf9szlmJ qsNFwSu4GfqM3hckpSzTmolSG4pYXteYvQNPUCRVx9RgMGzQ8sMgRvNTYbm0RFHf QLUR8cUebbISHPal2Hv3SAg5dcxl8gEgqrLbY5cKKHUCZuyPLVd2xdGWtYoLo6fD vl42V4u1oqJaLRtLdME29qA3cwEdsJXEcdWK3fvbFAmg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QqAGjQ y2Rv7S0crK1cGgBQzFGjyD3XT+R+oYDMxmbKM=; b=JTCOJppHT7Q5S65hf1c5B8 aau2Raqu+hfKTaZHst3GI5o0LochGBTyZOsmzO7msQ3AHLR506ay3tocT84j3qAw fWSIL+1Cxivp8c7KTQ4FopR10IRx/0AA5obtsBLuDhrZITsaXHp7p/yICpZgLwbN PgbzhgZMK3hoycS5Iq+hSyWFXVXVEADTo4Zcz1hck3DsZQQRPSr4gQbtV0kU1sxp 98CPlV/VHMA3t0koKCw7Nli7nsNpvLqPO/09RYobgy1kpBIDtmhk09ghMKVN4u3R zqPEDy15+EZn3LD6yXu3+DfnL7Th8oot7H4iVZDu/TFKi1act2J+Y3sZXx+PiqHA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddvkedgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffffkgggtsehgtderre dttddtnecuhfhrohhmpeetlhihshhsrgcutfhoshhsuceohhhisegrlhihshhsrgdrihhs qeenucggtffrrghtthgvrhhnpeduffeiueeltdehveehfeeiteevveffhfdvudethfeivd fgheeitdeffeelvefgudenucffohhmrghinhepshhpvggtthhruhhmqdhoshdrohhrghen ucfkphepjeelrddvfeehrdduudelrdduleegnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrihhs X-ME-Proxy: Received: from x220.qyliss.net (p4feb77c2.dip0.t-ipconnect.de [79.235.119.194]) by mail.messagingengine.com (Postfix) with ESMTPA id BBEAA30614FA; Fri, 29 May 2020 14:12:24 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id D6A212F2; Fri, 29 May 2020 18:12:22 +0000 (UTC) From: Alyssa Ross To: impaqt Subject: Re: [PATCH doc v2] Document crosvm memfd server In-Reply-To: References: Date: Fri, 29 May 2020 18:12:21 +0000 Message-ID: <875zcebofu.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: KXJZAEQTFZCSP363D5O42AKRTBRBCHTX X-Message-ID-Hash: KXJZAEQTFZCSP363D5O42AKRTBRBCHTX X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.0 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain > Looks good. One minor nitpick, take it or leave it: > >> +Spectrum's crosvm has been augmented with a feature called the "`memfd >> +server`", (currently only on the >> +https://spectrum-os.org/git/crosvm/log/?h=interguest[interguest] >> +branch). This is a small server that listens on a Unix stream socket. > > This should be either a comma or parenthesis, not both. Will fix, thank you. > This is just a personal preference of mine, but one I wish were > more widely adopted: when writing markdown I only wrap the "proper > nouns" in `code blocks` for consistency, e.g. "`memfd` server" not > "`memfd server`". But this isn't a hill I'm prepared to die on. I strongly agree! But this isn't Markdown. That's just the syntax for double quotes in AsciiDoctor. :) > Reviewed-by: impaqt > ^^^ Is this what you meant by a tag? Yes! Thank you. :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAl7RUIUACgkQ+dvtSFmy ccDtdBAAlJCNAIcOi/piaj3MM97RtJtf58CGRyl0u5H3oesYv/WigD59Mzj498vo 3n3GkEqcI53XuwBL1ziur+QN9vMbhQSAicMvkH9OUNYN6HjKWmPNRQUZ0cioFAN5 G64F4zoH+fNEK9z4vWHB/FDRWTAl+Gz1ODnOF1mskGCde9npj65qeQWFYpy6qYCl 85v/49RyjOxfcRNSkEN1x23EdU67jmsuNGieAg4y7Fn1HndwQW+q3+oXoRc1UBb6 k4zI+weYv+yCX2J4QnfvRXwDvjuEpjnbVAhoSHEra3mSR1tyC1b4Tq6KX39gCWYm VLElBvIo0RlAHlQySfFnZXf5IYcz1CY86ZTHqrNhKP+MrqCQn1svMxmZ1KiTTplC oN7Hkmp4mRdJR/7h/ROas+7grJ/Cu6BizZAP5Vz97XuJ19DlKH3dAXOLOu99MqkM sew2R2RyyY7JlvCjqy19/RE8zNbn6V3dTpZ52Yfq1hMSUFOdvTVzz5cWPESdXzVl FlYlwuMVhYb0s7xcJt0kMoWYTzFf+LLO/l/2YpOpGVcvQpohSp8T+1GmZ4Cn28YY JWXZC3moZzS2FS0/46wNEdt5ahPZyWBo9jnGTfuHqb9Iz8zfFqTtLuaXAWoOQuEv PciR0UX0EkCxzrR33SgiiZl0z2OKFDP3rMfLvBmCRHAisYl3sM4= =uK0b -----END PGP SIGNATURE----- --=-=-=--