From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id CAE8D87C9C; Fri, 30 Sep 2022 12:50:03 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 2A05187B96; Fri, 30 Sep 2022 12:49:55 +0000 (UTC) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by atuin.qyliss.net (Postfix) with ESMTPS id 8530D87B74 for ; Fri, 30 Sep 2022 12:49:50 +0000 (UTC) Received: by mail-ej1-x636.google.com with SMTP id sb3so8782617ejb.9 for ; Fri, 30 Sep 2022 05:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unikie.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=4/E3GFrKKiXBCtmxVcraWODokhIlwXg4UHsa6CQvPGQ=; b=HlqKAz9bKawinsvRaq9H0cEf8m+KmLn982UHHVUWdpc+d+KuDaKfgAe1noTYrNWzvZ 7XXo0ZB5DduKsMHwTjElC/gkNFJTBR/KIXzToloGbTt+5p9Yl6luo/wAX03ummT8xZCL u2OV6HSiz4Gp3eliDgGegLSn4ZQ1hCTgJul3L4VsjvC0MTm5JJ4N6KbFM+OqPlGuIfPq FW2z9Bfotj1h3dikQJvoqtV9aGS/aCWxJihpq560Sje2gtUtx6NZYPsqpzj2RwjKuDSv 3LVOfnruwiJmLMojC0j9ckIl66suohKoPuBw6fz5y7wkp6Cv13elj0X9ryY4MfoDjZnd /b/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=4/E3GFrKKiXBCtmxVcraWODokhIlwXg4UHsa6CQvPGQ=; b=7K5W3P5uQ7v9UGxifPs0MBQbN1ucn5JxeQCMj/1EyEvSyl3FJ0idEwiPSGJavxLyAk L769Kp6kqCnvdJOQoQj6jpkqy84kP0u8p7FVm7HlKIcFJ/eRYHnV9c1JsBPjDHQFCXXy ozYpkfvVNa1cml2mbOnh44WuOy6LGLS/DBHcw7mFwQBHXtFjZlwB2aZhqtO3HR7Djh64 PMLbgs455/Y2SSzq0tq+fXWehXt6RlqhTl7ypFm6nFAX9LRqaa6bPscZpmuDgLdfLFkH EAWbQjgXDkfVoPnx4v3e5RwWRycMsjJi7qf8oHrmYGbwI/tuebRl0jPdyv42MaXKnqAX PuwQ== X-Gm-Message-State: ACrzQf2Ff20WP0CunDFr+RIfai7eDeVl09yWlRa0gvpXyea54GBMDZIF +tnjZG8+QJw8Of5vmhkbPduhIQ== X-Google-Smtp-Source: AMsMyM6aJwQGzOitQr0dznmDiIgfsn31lyo7v9+kv1MgIZVt/du8fS3+29kDpMf5qtsbj8tYCnR6Ag== X-Received: by 2002:a17:906:ef8c:b0:77c:8f77:330 with SMTP id ze12-20020a170906ef8c00b0077c8f770330mr6325171ejb.604.1664542190034; Fri, 30 Sep 2022 05:49:50 -0700 (PDT) Received: from x220.qyliss.net (p54b8e692.dip0.t-ipconnect.de. [84.184.230.146]) by smtp.gmail.com with ESMTPSA id c9-20020a17090618a900b0077b2b0563f4sm1141384ejf.173.2022.09.30.05.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 05:49:49 -0700 (PDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 644554F7; Fri, 30 Sep 2022 12:49:48 +0000 (UTC) From: Alyssa Ross To: devel@spectrum-os.org Subject: [RFC PATCH 02/10] img/app: don't block app startup on network online Date: Fri, 30 Sep 2022 12:49:32 +0000 Message-Id: <20220930124940.1013577-3-alyssa.ross@unikie.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220930124940.1013577-1-alyssa.ross@unikie.com> References: <20220930124940.1013577-1-alyssa.ross@unikie.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: XIFNYZ4P3LJBIEFBQZL4KZH7JG2M4AQA X-Message-ID-Hash: XIFNYZ4P3LJBIEFBQZL4KZH7JG2M4AQA X-MailFrom: alyssa.ross@unikie.com X-Mailman-Rule-Hits: header-match-devel.spectrum-os.org-0 X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1 CC: Puck Meerburg , Ville Ilvonen X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Alyssa Ross Not all VMs will even have networking! So it makes more sense to put waiting for the network in the application-specific part. The "listen" and "wait" scripts are copied from the host system. Signed-off-by: Alyssa Ross --- This patch comes from before I started working on this at Unikie, hence the non-Unikie author email. img/app/Makefile | 2 ++ img/app/etc/mdev/iface | 2 +- img/app/etc/mdev/listen | 12 ++++++++++++ img/app/etc/mdev/wait | 15 +++++++++++++++ img/app/etc/s6-rc/ok-all/contents | 1 + vm/app/catgirl.nix | 1 + vm/app/lynx.nix | 1 + 7 files changed, 33 insertions(+), 1 deletion(-) create mode 100755 img/app/etc/mdev/listen create mode 100755 img/app/etc/mdev/wait diff --git a/img/app/Makefile b/img/app/Makefile index c5a4684..a3fefc3 100644 --- a/img/app/Makefile +++ b/img/app/Makefile @@ -47,6 +47,8 @@ VM_FILES = \ etc/init \ etc/mdev.conf \ etc/mdev/iface \ + etc/mdev/listen \ + etc/mdev/wait \ etc/passwd \ etc/resolv.conf \ etc/s6-linux-init/scripts/rc.init diff --git a/img/app/etc/mdev/iface b/img/app/etc/mdev/iface index d8ceda5..4cdc112 100755 --- a/img/app/etc/mdev/iface +++ b/img/app/etc/mdev/iface @@ -33,4 +33,4 @@ foreground { } } -s6-rc -u change app +/etc/mdev/listen network-online diff --git a/img/app/etc/mdev/listen b/img/app/etc/mdev/listen new file mode 100755 index 0000000..6bc6f2c --- /dev/null +++ b/img/app/etc/mdev/listen @@ -0,0 +1,12 @@ +#!/bin/execlineb -s1 +# SPDX-License-Identifier: EUPL-1.2+ +# SPDX-FileCopyrightText: 2021 Alyssa Ross + +foreground { + redirfd -w 2 /dev/null + foreground { mkdir /run/wait } + mkfifo /run/wait/${1} +} + +redirfd -w 1 /run/wait/${1} +echo diff --git a/img/app/etc/mdev/wait b/img/app/etc/mdev/wait new file mode 100755 index 0000000..3b85de8 --- /dev/null +++ b/img/app/etc/mdev/wait @@ -0,0 +1,15 @@ +#!/bin/execlineb -s1 +# SPDX-License-Identifier: EUPL-1.2+ +# SPDX-FileCopyrightText: 2021 Alyssa Ross + +foreground { + redirfd -w 2 /dev/null + foreground { mkdir /run/wait } + mkfifo /run/wait/${1} +} + +foreground { + redirfd -w 1 /dev/null + head -1 /run/wait/${1} +} +rm /run/wait/${1} diff --git a/img/app/etc/s6-rc/ok-all/contents b/img/app/etc/s6-rc/ok-all/contents index c4ea84f..92f3ef1 100644 --- a/img/app/etc/s6-rc/ok-all/contents +++ b/img/app/etc/s6-rc/ok-all/contents @@ -2,3 +2,4 @@ # SPDX-FileCopyrightText: 2021 Alyssa Ross # mdevd-coldplug +app diff --git a/vm/app/catgirl.nix b/vm/app/catgirl.nix index 107ff82..79c5d8b 100644 --- a/vm/app/catgirl.nix +++ b/vm/app/catgirl.nix @@ -10,6 +10,7 @@ import ../../vm-lib/make-vm.nix { inherit config; } { { writeScript, catgirl }: writeScript "run-catgirl" '' #!/bin/execlineb -P + if { /etc/mdev/wait network-online } foreground { printf "IRC nick (to join #spectrum): " } backtick -E nick { head -1 } ${catgirl}/bin/catgirl -h irc.libera.chat -j "#spectrum" -n $nick diff --git a/vm/app/lynx.nix b/vm/app/lynx.nix index 8fc3bd6..6abaf9b 100644 --- a/vm/app/lynx.nix +++ b/vm/app/lynx.nix @@ -10,6 +10,7 @@ import ../../vm-lib/make-vm.nix { inherit config; } { { writeScript, lynx }: writeScript "run-lynx" '' #!/bin/execlineb -P + if { /etc/mdev/wait network-online } ${lynx}/bin/lynx https://spectrum-os.org '' ) { }; -- 2.37.1