From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 5A6F44370; Fri, 9 Apr 2021 22:26:21 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id E62014356; Fri, 9 Apr 2021 22:26:15 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id E0E5142B6; Fri, 9 Apr 2021 22:26:13 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by atuin.qyliss.net (Postfix) with ESMTPS id A1A3D42B4 for ; Fri, 9 Apr 2021 22:26:11 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0049B5C00AA; Fri, 9 Apr 2021 18:26:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 09 Apr 2021 18:26:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=Puy9lzZEoV+zmQ1azDXyDQGTHx/ six/hhI7Pl44XSoM=; b=Li9xUwWjZwrgs6Q+YrG4V0P7e3Mc1k1uoQqV0Bzivk8 0MsoXFE9J3rnhwnILmVrzSYo4FC7VTInj+zmxiiCST8Z5V4/MbFue2ejvtXNzx9T eH9eLN2JshnHcU2zOyOb5aMPxVBcqu9ya6qGFDJKWJwc38kgWQNWt0Axo/CebZE1 GAOom9vGIhMclPxylQ79FNZqSDDqfxuRetS33bBZYhu8+RVOypY8QzZwt6rqqdhH ib3ndfbIaNKX32tyTVhKW/QHPCGxFkVDeb14zjC9Ijkh4SclgFWGLCa5YMhV4bXW NempyWEzXLND6gtA9bImi+uK/dDzi6WE0HqHymKFQ2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Puy9lz ZEoV+zmQ1azDXyDQGTHx/six/hhI7Pl44XSoM=; b=hLMEzlSsXPsJytGXeBGabN dsFo4egzE09wY9z1P78F0LDNQoanGBNdMEd21yHX49nCrFB/ydrMScqe67ZPs3xD LfxxFg2PMTZxKnXT1BSKON9sFXt8NWOPTint3uTIR0JpXYQnmxabKALLtk7skUqa NwIDJvFZDpUrrTQdDW+c9hlBlxaGXyqQhzPYEn3bKSuouEi/ZMsV3nNHgwMsSGm/ TMe/fCsFOqRRZaCqIoMJlWtG8m7RUm8Xa/H9pE06SCl2amtzVqM/nSrIqs+EYNi7 F/wEa/4ZaUm7GhYRFk5mywxlYJkNJO2X6psE46a2yUXRCZvLd+vEWr7rX3P9Mjkg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekvddgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtddtredttddvnecuhfhrohhmpeetlhihshhs rgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeeufe dviefhheevkeehffefgedtffehfeegleduvdevtedtvdeltdehvefgfeekhfenucffohhm rghinhepohgrshhishdqohhpvghnrdhorhhgnecukfhppeejledrvdefhedrudduledrud dtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehq hihlihhsshesgidvvddtrdhqhihlihhsshdrnhgvth X-ME-Proxy: Received: from x220.qyliss.net (p4feb776b.dip0.t-ipconnect.de [79.235.119.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 2F959240057; Fri, 9 Apr 2021 18:26:10 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 01B1D11BD; Fri, 9 Apr 2021 22:26:07 +0000 (UTC) Date: Fri, 9 Apr 2021 22:26:07 +0000 From: Alyssa Ross To: devel@spectrum-os.org Subject: Re: [PATCH crosvm] crosvm: support setting guest MAC from tap-fd Message-ID: <20210409222607.p427pp4b7axylnu7@x220.qyliss.net> References: <20210409222026.13886-1-hi@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4yr6l553j5qrrhue" Content-Disposition: inline In-Reply-To: <20210409222026.13886-1-hi@alyssa.is> Message-ID-Hash: D6NX5PJW7OHKBQJTUCF6ZTPYVXX4PEUN X-Message-ID-Hash: D6NX5PJW7OHKBQJTUCF6ZTPYVXX4PEUN X-MailFrom: qyliss@x220.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Puck Meerburg X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: --4yr6l553j5qrrhue Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 09, 2021 at 10:20:26PM +0000, Alyssa Ross wrote: > This adds a mac= option to crosvm's --tap-fd option. The virtio-net > driver in the guest will read the desired MAC from virtio > configuration space. > > See the documentation for VIRTIO_NET_F_MAC in the Virtio spec[1]. > > [1]: https://docs.oasis-open.org/virtio/virtio/v1.1/virtio-v1.1.html Oh, I forgot to add: Thanks-to: Puck Meerburg > --- > This will be important for host-based networking in Spectrum. > > devices/src/virtio/net.rs | 31 ++++++++++++++++--- > src/crosvm.rs | 8 +++-- > src/linux.rs | 20 +++++++----- > src/main.rs | 64 ++++++++++++++++++++++++++++++--------- > 4 files changed, 96 insertions(+), 27 deletions(-) --4yr6l553j5qrrhue Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmBw1GsACgkQ+dvtSFmy ccCy1Q/+K0gLvANoP4Gnjdk/KaLWFny88Kp3L5oAyearPP88W67rxHmcZCQseoJq TMG6J9umv6Ye8nC7PHnhRsRZ4ET5cjHQ96IR1oCJf9Z13woRiahoNxqiJdt/3aZq 1OtoWbTC1ohUVDlOYc/4OLmEcbPY18FJeffZdNMiF7L4EJj9lBskfqTX0/Nx03Mc S5OcZE/qOwHMHldewg959Fi+YcZuNIB1jKGgLF0IGct5zfXMYKV1NQpryIRDpCug qr0FFX0IllLo155Tl+JBc4K+3OMcJEFfgG8t3hPqYlrAvOqjE1JToq+bP0Fwgil8 K5f0YSk0+v4BXOloE7Ouoa3+lBUzkf1R3ukD0kG5GlO6+0xb0+K3ImM0FNThbW2o Wv5ICGa6R8OXp/OI7iemAx1r6im0uLCtOo7v1YdiDb8rqQSjUiwMZST2/KVFVpFM VYb9WHUTsZj4jRdCjR6kj35EGFygNy8+hX+OU6t0t5KrNObYnmpPIyX1JRxRzhAo FgMQDTpBWS5f1W8ttqjDPUCQwunIGf3Ew9MGVw68R40UVcCt4RARIU4rYOewBapz ApSwjBfJ5+25qqHBJ6fkxbAYW0ndBhspXWQrqt+kTlZ3dvYs59JZpfvAEYCwNJ2H lvD0J5W9tx82B2AWxc1O07gbUO9VjjK+lScHbTLlngIoKLWyPeI= =e4g1 -----END PGP SIGNATURE----- --4yr6l553j5qrrhue--