From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 548D4B9F5; Sun, 21 Mar 2021 14:47:40 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id F00E7B973; Sun, 21 Mar 2021 14:47:24 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 102B5B9C5; Sun, 21 Mar 2021 14:47:23 +0000 (UTC) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by atuin.qyliss.net (Postfix) with ESMTPS id 05450B9C3 for ; Sun, 21 Mar 2021 14:47:19 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2E6035C003D; Sun, 21 Mar 2021 10:47:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 21 Mar 2021 10:47:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=IqmveVdplt2w1AAXJ5yswF953l EOCOo9CjcY9y7q7Ag=; b=anUj3j9h+Netn1F8wTwg+VVtSNs5exAlbYAihmkHKy XlKzQtcCT2c228T2r1TKDaz79Rhi+gEwZxTMHMTqJ0u50459+J88wDCf/pJlw6o7 sqmKR67nFLsPFhmZlNlFyDWo0cPczFIrwuKA3gMwygJm0GskQ4sYqJ0ZiPNVhwpo GjIsbfT7/wFCAoD3ZE65ZVKR/lke0HiF9vLj7jDWDH3j8xYQs6OiGFl2hI5VAwCr EZ8icD7vGI71CQ4TUNCktBEygk5dUyc+aLqqQqEXnM8BaRTIZzQI5koZrvP5lSBY Ox5LiZQFYeX7/yumxh8Qnwn3TYHPcliKWvy9TmTz3lSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=IqmveVdplt2w1AAXJ 5yswF953lEOCOo9CjcY9y7q7Ag=; b=a+9XbsrfdNUCtsRqYY+6wDMF6qvPaiL6s skovrcQWVnDoNU/DUdatwmV+MGMcbMJA+TX38pZIiUtHcGxrakn+rOvV+KJAXi2J MpF+CRvxwYfFSiipmQvrO/VkhHj3wTE4UNbEft86g0+XXqUVlFUdEsaqoIz3PuQB nupSzhYTcp92lunRaD93bo+7+L/p0IQcEs5x+vSA6m610/nDmWoNHJsDdpSmOO/R GnaDokdcMAoYDI1HHV2uNK7ENsuO3GCsLlXx2ekbkNiTNq1XhngR6c6jB2pA2dCV A4M1jssptDpBEZ/z0xBXBPDpsg5cxOTPqSyrvArM5B6M0G3aKVPag== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegvddgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeetlhihshhsrgcu tfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeelfeelfe fguefgleejtdeufeevkeegtdffvdetudefhfejfffgfeefueelgeelffenucffohhmrghi nhepfihikhhiphgvughirgdrohhrghenucfkphepjeelrddvfedurddvgeefrdekudenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehqhihlihhs shesvghvvgdrqhihlhhishhsrdhnvght X-ME-Proxy: Received: from eve.qyliss.net (p4fe7f351.dip0.t-ipconnect.de [79.231.243.81]) by mail.messagingengine.com (Postfix) with ESMTPA id 94A7C24016D; Sun, 21 Mar 2021 10:47:18 -0400 (EDT) Received: by eve.qyliss.net (Postfix, from userid 1000) id D7CCF11DC; Sun, 21 Mar 2021 14:47:17 +0000 (UTC) From: Alyssa Ross To: devel@spectrum-os.org Subject: [PATCH ucspi-vsock 0/2] Fix clang-tidy warnings Date: Sun, 21 Mar 2021 14:46:58 +0000 Message-Id: <20210321144700.24024-1-hi@alyssa.is> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: SSIRLR54S7WJPL66GGGX7CRMMQIL7BGT X-Message-ID-Hash: SSIRLR54S7WJPL66GGGX7CRMMQIL7BGT X-MailFrom: qyliss@eve.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Cole Helbling X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: clang-tidy also produced this warning: /home/src/ucspi-vsock/repro.c:43:19: warning: unused parameter 'sig' [clang-diagnostic-unused-parameter] void sig_exit(int sig) { exit(EX_UNAVAILABLE); } ^ vsock.c:27:23: warning: The left operand of '!=' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult] if (addr->svm_family != AF_VSOCK) { ^ vsock.c:90:6: note: Assuming the condition is false if (getsockname(fd, (struct sockaddr *)&addr, &addrlen) == -1) ^ vsock.c:90:2: note: Taking false branch if (getsockname(fd, (struct sockaddr *)&addr, &addrlen) == -1) ^ vsock.c:93:9: note: Calling 'fill_cid_and_port' return fill_cid_and_port(&addr, cid, port); ^ vsock.c:27:23: note: The left operand of '!=' is a garbage value if (addr->svm_family != AF_VSOCK) { But I think this is just warning me that the POSIX socket API violates the strict aliasing rule. (Which is true, but there's not a lot I can do about it...) It also tells me I should use memset_s instead of memset, but, well... https://en.wikipedia.org/wiki/C11_(C_standard_revision)#Criticism Alyssa Ross (2): exec: free argv if exec fails vsockserver: fix uninitialized variable exec.c | 5 ++++- vsockserver.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) -- 2.30.0