From: Alyssa Ross <hi@alyssa.is>
To: Cole Helbling <cole.e.helbling@outlook.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH ucspi-vsock] vsockserver: use fclose instead of close
Date: Wed, 10 Mar 2021 22:43:16 +0000 [thread overview]
Message-ID: <20210310224316.hbtujxmcyvd2ophq@eve.qyliss.net> (raw)
In-Reply-To: <SJ0PR03MB5581E4B3D5422B4ADA2BD6B7B3919@SJ0PR03MB5581.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]
On Wed, Mar 10, 2021 at 09:41:01AM -0800, Cole Helbling wrote:
> On Tue Mar 9, 2021 at 7:40 AM PST, Alyssa Ross wrote:
> > stdio can buffer output, so if we close stdout without going through
> > stdio, there might be buffered output that is never written.
> > ---
> > vsockserver.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/vsockserver.c b/vsockserver.c
> > index dd9a74a..196056a 100644
> > --- a/vsockserver.c
> > +++ b/vsockserver.c
> > @@ -90,7 +90,7 @@ int main(int argc, char *argv[])
> >
> > if (notify) {
> > printf("%" PRIu32 "\n", lport);
> > - close(STDOUT_FILENO);
> > + fclose(stdout);
> > }
> >
> > setenvf("VSOCKLOCALCID", 1, "%" PRIu32, lcid);
> > --
> > 2.30.0
>
> I don't write much (if any) C, so I never knew there was both
> STDOUT_FILENO (as an int) _and_ stdout (as a FILE*). I suppose the most
> important part is that fclose() uses fflush(3) under the hood to make
> sure we actually write everything.
Yeah, C on UNIX essentially gives you two different IO interfaces
(open/write/close/etc. from POSIX, and fopen/fprintf/fclose/etc. from
stdio in the C standard library). The POSIX stuff doesn't know
anything about the buffering that stdio does on top of it. Mixing them
is probably never a good idea if you're not doing it very deliberately.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-03-10 22:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 15:40 Alyssa Ross
2021-03-10 17:41 ` Cole Helbling
2021-03-10 22:43 ` Alyssa Ross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310224316.hbtujxmcyvd2ophq@eve.qyliss.net \
--to=hi@alyssa.is \
--cc=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).