From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 5194A15216; Wed, 10 Mar 2021 20:46:25 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id E58AF1518A; Wed, 10 Mar 2021 20:46:13 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id F385D15161; Wed, 10 Mar 2021 20:46:11 +0000 (UTC) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by atuin.qyliss.net (Postfix) with ESMTPS id 0150C150F1 for ; Wed, 10 Mar 2021 20:46:08 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 6D76F5C00EE for ; Wed, 10 Mar 2021 15:46:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 10 Mar 2021 15:46:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=3JmqLcHjsb4Wmnqs0xMsutomO3 gfQS1W7aHcnKCmGQI=; b=mxEC1xbxIgzTEbgIYGpcFu1gbKxevYj1lsSTdk468C rySo3ZtSTBN4WFd2HqP34ZD771RFoF20vaMxrlKUgnnR+1EUVuFictGmBOJqK9Gk cBS3uJzOA8QAP6+5KfKJeg/NLKPPCcVTM3oLjrPgE6BROp2740MswHWic3ohyX7Q In9aP1xFOLAYQp04O1GtZmx3WGwQMc20eOZkHlQpOBCok7UpnjMM+l0NgVbZZXCt O8AE0CV7CYpXsoIa5Z/C5SW7ccsMC2pbi7dePPjDZUZV6MIkd7cmWtIwyOCBeXsF ypu7iaN156xFsD3qu/94uVBsdgcvayn7yP4kPwyte/hg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=3JmqLcHjsb4Wmnqs0 xMsutomO3gfQS1W7aHcnKCmGQI=; b=qEyaodh58TkmnphF2UaW8L+xUM8YD0gFN svNMHbIllBminOZSHlTN+q2GM7YDdPEe6JuRWngysKFtU7j7JSUxFdrSrymE8HPY HJ02PzNMWcH29sFuDQU5ahUIxhlr+s/NyOQiEr5YZ49hkGKkcJnHGSlxTOF5wRkK n3IEovjiJzzZ29qibOvK1qYW7X67LkNaIzy2KN9KRIdftIG+B7mfTYQpr2VpWtsn Uqa/zAEyPSoY+Crjqjt4rWJA8v4C1GduH1wFWWqyzr7eCDHz0JORoqoC4YHqeRvL sPtsKSMOogG+zRk6Qb4SIV3f9o8pei0+kJoCDl4k1v6btsdd6FCSA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddukedgudegudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpeetlhihshhsrgcutfhoshhsuceohhhisegrlhihshhsrgdrihhs qeenucggtffrrghtthgvrhhnpeehvdffgffhteeijefgteeftdfghfdvheeuhedvjedugf eggfeljefgleefvefgfeenucfkphepkeegrddukedurddvheehrdekheenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehqhihlihhsshesvghvvg drqhihlhhishhsrdhnvght X-ME-Proxy: Received: from eve.qyliss.net (p54b5ff55.dip0.t-ipconnect.de [84.181.255.85]) by mail.messagingengine.com (Postfix) with ESMTPA id E8AA31080059 for ; Wed, 10 Mar 2021 15:46:06 -0500 (EST) Received: by eve.qyliss.net (Postfix, from userid 1000) id 4EE4026B; Wed, 10 Mar 2021 20:46:05 +0000 (UTC) From: Alyssa Ross To: devel@spectrum-os.org Subject: [PATCH ucspi-vsock] Makefile: link object files instead of source files Date: Wed, 10 Mar 2021 20:45:55 +0000 Message-Id: <20210310204555.20725-1-hi@alyssa.is> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CQTDAARJME4JSGFKSPDBUBG27VF652BJ X-Message-ID-Hash: CQTDAARJME4JSGFKSPDBUBG27VF652BJ X-MailFrom: qyliss@eve.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Previously this would (I assume) needlessly recompile vsockserver.c and vsockclient.c when Make has already automatically compiled those. GNU Make has an automatic variable, $+, that we could use here, but currently the Makefile is portable, and it would be a shame to require GNU Make just for that. --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index b931c89..4f11b64 100644 --- a/Makefile +++ b/Makefile @@ -19,9 +19,9 @@ install: vsockclient vsockserver .PHONY: install =20 vsockclient: vsockclient.o env.o log.o util.o vsock.o - $(CC) $(LDFLAGS) -o vsockclient vsockclient.c env.o log.o util.o vsock.= o $(LDLIBS) + $(CC) $(LDFLAGS) -o vsockclient vsockclient.o env.o log.o util.o vsock.= o $(LDLIBS) vsockserver: vsockserver.o env.o log.o util.o vsock.o - $(CC) $(LDFLAGS) -o vsockserver vsockserver.c env.o log.o util.o vsock.= o $(LDLIBS) + $(CC) $(LDFLAGS) -o vsockserver vsockserver.o env.o log.o util.o vsock.= o $(LDLIBS) =20 vsockclient.o: env.h log.h util.h vsock.h vsockserver.o: env.h log.h util.h vsock.h --=20 2.30.0