From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Subject: [PATCH ucspi-vsock] Makefile: link object files instead of source files
Date: Wed, 10 Mar 2021 20:45:55 +0000 [thread overview]
Message-ID: <20210310204555.20725-1-hi@alyssa.is> (raw)
Previously this would (I assume) needlessly recompile vsockserver.c
and vsockclient.c when Make has already automatically compiled those.
GNU Make has an automatic variable, $+, that we could use here, but
currently the Makefile is portable, and it would be a shame to require
GNU Make just for that.
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index b931c89..4f11b64 100644
--- a/Makefile
+++ b/Makefile
@@ -19,9 +19,9 @@ install: vsockclient vsockserver
.PHONY: install
vsockclient: vsockclient.o env.o log.o util.o vsock.o
- $(CC) $(LDFLAGS) -o vsockclient vsockclient.c env.o log.o util.o vsock.o $(LDLIBS)
+ $(CC) $(LDFLAGS) -o vsockclient vsockclient.o env.o log.o util.o vsock.o $(LDLIBS)
vsockserver: vsockserver.o env.o log.o util.o vsock.o
- $(CC) $(LDFLAGS) -o vsockserver vsockserver.c env.o log.o util.o vsock.o $(LDLIBS)
+ $(CC) $(LDFLAGS) -o vsockserver vsockserver.o env.o log.o util.o vsock.o $(LDLIBS)
vsockclient.o: env.h log.h util.h vsock.h
vsockserver.o: env.h log.h util.h vsock.h
--
2.30.0
next reply other threads:[~2021-03-10 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 20:45 Alyssa Ross [this message]
2021-03-10 20:50 ` Cole Helbling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310204555.20725-1-hi@alyssa.is \
--to=hi@alyssa.is \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).