From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 2739C13786; Tue, 9 Mar 2021 15:41:26 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 9A54013758; Tue, 9 Mar 2021 15:41:16 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 056311373F; Tue, 9 Mar 2021 15:41:14 +0000 (UTC) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by atuin.qyliss.net (Postfix) with ESMTPS id 5089C1373E for ; Tue, 9 Mar 2021 15:41:09 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id C8A6E5C00D9 for ; Tue, 9 Mar 2021 10:41:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 09 Mar 2021 10:41:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=Mn0U5An57pItElwsKw1O+b7hFV W7GEgQrf5u0b3s30U=; b=WJMLioZxDj3LmmeAPR1x39gWETgY5/A+Kc4h+siif2 nCeNrSLGyH4mpcy/LzASd3r5Vcys4KAnS+jzTy0ida+SqnegeJRa+VuFGFNHs18I XQrPBcHpzSKgeZeK2Ra5kh5mKTRrXMxECW6K72fI3LOti/e2HKRzT6mdjVt+4U3X HIEtjvajGvbw6/Q/4spN+B1qeJcLeBv19/TZzI8v9hcOuNX8Rs5bV11eP/n5w6Sl YUHwtLUlqNEwtA5V2zvrw/wR+yyQ5aGLcdTO58zuNi7LIf+B8SAXz5sGLxtruGu3 SKOB3BOeMfDUIwIKUBtQeEVn3+OZcAr9JaXyOLjsXHjg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Mn0U5An57pItElwsK w1O+b7hFVW7GEgQrf5u0b3s30U=; b=oNlLHfEUK3TnYipYilViy1kdw8nFC5ye4 XcAoxNW6vsTn0y8RlLP32dXdEmMqE8g0hStdU94l52NottFLBl0+HfRu4w731uUm H2c1EeN+McIdiRbzWyNB+ESuKeBA0USv5LEdPJ+ePLYH2/Osk+fu3G9V/LGBTQGP QgGqlJlIv2pNiXchwnpdPl6S/yJgnV3TfqMRl6IZlgAYzgMCcykGnMGkCKOeW0EF MMiL3KJyxmOgI5clZYAozSQ2IrI2O+scFO0gd43g2K2Gs1XvViuQ2CetyhZ/DuaB GWP6at2V+8kS2DqqMCF88F911s/y202A4VzvmxOShE/qdw9yl7ciw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudduiedgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomheptehlhihsshgrucftohhsshcuoehhihesrghlhihsshgrrdhisheq necuggftrfgrthhtvghrnhephedvfffghfetieejgfetfedtgffhvdehueehvdejudfgge fgleejgfelfeevgfefnecukfhppeejledrvdefhedruddvvddrudegheenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehqhihlihhsshesgidvvd dtrdhqhihlihhsshdrnhgvth X-ME-Proxy: Received: from x220.qyliss.net (p4feb7a91.dip0.t-ipconnect.de [79.235.122.145]) by mail.messagingengine.com (Postfix) with ESMTPA id C4F68240066 for ; Tue, 9 Mar 2021 10:41:05 -0500 (EST) Received: by x220.qyliss.net (Postfix, from userid 1000) id C430410F1; Tue, 9 Mar 2021 15:41:03 +0000 (UTC) From: Alyssa Ross To: devel@spectrum-os.org Subject: [PATCH ucspi-vsock] vsockserver: use fclose instead of close Date: Tue, 9 Mar 2021 15:40:48 +0000 Message-Id: <20210309154048.14474-1-hi@alyssa.is> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: MYCRRVTXDHMOFCOXEPXVYUKHISH64CKH X-Message-ID-Hash: MYCRRVTXDHMOFCOXEPXVYUKHISH64CKH X-MailFrom: qyliss@x220.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: stdio can buffer output, so if we close stdout without going through stdio, there might be buffered output that is never written. --- vsockserver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vsockserver.c b/vsockserver.c index dd9a74a..196056a 100644 --- a/vsockserver.c +++ b/vsockserver.c @@ -90,7 +90,7 @@ int main(int argc, char *argv[]) =20 if (notify) { printf("%" PRIu32 "\n", lport); - close(STDOUT_FILENO); + fclose(stdout); } =20 setenvf("VSOCKLOCALCID", 1, "%" PRIu32, lcid); --=20 2.30.0