patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <>
Subject: [PATCH ucspi-vsock] vsockserver: use fclose instead of close
Date: Tue,  9 Mar 2021 15:40:48 +0000	[thread overview]
Message-ID: <> (raw)

stdio can buffer output, so if we close stdout without going through
stdio, there might be buffered output that is never written.
 vsockserver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vsockserver.c b/vsockserver.c
index dd9a74a..196056a 100644
--- a/vsockserver.c
+++ b/vsockserver.c
@@ -90,7 +90,7 @@ int main(int argc, char *argv[])
 	if (notify) {
 		printf("%" PRIu32 "\n", lport);
-		close(STDOUT_FILENO);
+		fclose(stdout);
 	setenvf("VSOCKLOCALCID", 1, "%" PRIu32, lcid);

             reply	other threads:[~2021-03-09 15:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 15:40 Alyssa Ross [this message]
2021-03-10 17:41 ` Cole Helbling
2021-03-10 22:43   ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).