patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Nicolas Braud-Santoni <nicoo@debian.org>
To: devel@spectrum-os.org
Subject: [PATCH] start-vm: Remove rngd (unecessary since the introduction of khwrngd)
Date: Sun, 29 Dec 2019 18:09:06 +0100	[thread overview]
Message-ID: <20191229170906.362205-1-nicoo@debian.org> (raw)

khwrngd provides the same functionality as rngd here, but is integrated in the
kernel, and started by default by the hwrng driver as soon as the device is
initialized.

It was added in Linux 3.17 by the following commit:

commit be4000bc4644d027c519b6361f5ae3bbfc52c347
Author: Torsten Duwe <duwe@lst.de>
Date:   Sat Jun 14 23:46:03 2014 -0400

    hwrng: create filler thread

    This can be viewed as the in-kernel equivalent of hwrngd;
    like FUSE it is a good thing to have a mechanism in user land,
    but for some reasons (simplicity, secrecy, integrity, speed)
    it may be better to have it in kernel space.

    This patch creates a thread once a hwrng registers, and uses
    the previously established add_hwgenerator_randomness() to feed
    its data to the input pool as long as needed. A derating factor
    is used to bias the entropy estimation and to disable this
    mechanism entirely when set to zero.
---
 start-vm.nix | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/start-vm.nix b/start-vm.nix
index 442f83a8f45..66fb358cb39 100644
--- a/start-vm.nix
+++ b/start-vm.nix
@@ -45,14 +45,6 @@ let
             s6-linux-init-hpr -fr
           '';
         } // services.".s6-svscan" or {};
-
-        rngd = {
-          run = writeScript "rngd-run" ''
-            #! ${execline}/bin/execlineb -P
-            ${rng-tools}/bin/rngd -f -x pkcs11,rdrand
-          '';
-        } // services.rngd or {};
-
       } // services;
 
     in
-- 
2.24.0

             reply	other threads:[~2019-12-29 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-29 17:09 Nicolas Braud-Santoni [this message]
2019-12-29 17:46 ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191229170906.362205-1-nicoo@debian.org \
    --to=nicoo@debian.org \
    --cc=devel@spectrum-os.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).