host/start-vm: don't allow VM name to contain ','

cloud-hypervisor would misintepret these if they were passed on its
command line.

1 files changed, 14 insertions, 0 deletions

diff --git a/host/start-vm/start-vm.rs b/host/start-vm/start-vm.rs
index 484fd60..ab856ea 100644
--- a/host/start-vm/start-vm.rs
+++ b/host/start-vm/start-vm.rs
@@ -21,6 +21,10 @@ fn vm_command(dir: PathBuf) -> Result<Command, String> {
         .file_name()
         .ok_or_else(|| "directory has no name".to_string())?;
 
+    if vm_name.as_bytes().contains(&b',') {
+        return Err(format!("VM name may not contain a comma: {:?}", vm_name));
+    }
+
     let mut command = Command::new("s6-notifyoncheck");
     command.args(&["-dc", "test -S env/cloud-hypervisor.sock"]);
     command.arg("cloud-hypervisor");
@@ -110,3 +114,13 @@ fn main() {
     eprintln!("{}: {}", argv0, run());
     exit(1);
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn test_vm_name_comma() {
+        assert!(vm_command("/v,m".into()).unwrap_err().contains("comma"));
+    }
+}