From 2a894cd2d14e0858d4942cf3d15c188372c3a121 Mon Sep 17 00:00:00 2001 From: aszlig Date: Thu, 9 Nov 2017 02:21:00 +0100 Subject: lxc: Fix build error with glibc 2.26 This issue doesn't necessarily have to do with glibc 2.26 and it could have been fixed if we'd replace -Werror with -Wall. The error in question was: storage/overlay.c:808:13: error: 'dirlen' may be used uninitialized in this function [-Werror=maybe-uninitialized] After looking at the code in overlay.c it indeed might use dirlen unitialized. Unrelated to the glibc upgrade which brought the problem to the surface, this also has been fixed upstream at lxc/lxc@180c477a326ce85632249ff169. The reason however, that led to the upstream fix was a segfault which has been reported at lxc/lxc#1802. Signed-off-by: aszlig Cc: @wkennington, @globin, @fpletz --- pkgs/os-specific/linux/lxc/default.nix | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'pkgs') diff --git a/pkgs/os-specific/linux/lxc/default.nix b/pkgs/os-specific/linux/lxc/default.nix index f818d2c0d8c..2660f299262 100644 --- a/pkgs/os-specific/linux/lxc/default.nix +++ b/pkgs/os-specific/linux/lxc/default.nix @@ -29,6 +29,12 @@ stdenv.mkDerivation rec { patches = [ ./support-db2x.patch + # Fix build error against glibc 2.26 + (fetchpatch { + url = "https://github.com/lxc/lxc/commit/" + + "180c477a326ce85632249ff16990e8c29db1b6fa.patch"; + sha256 = "05jkiiixxk9ibj1fwzmy56rkkign28bd9mrmgiz12g92r2qahm2z"; + }) ]; postPatch = '' -- cgit 1.4.1