From 0030c6610353b3706fe77d4cce06f1905a4aec43 Mon Sep 17 00:00:00 2001 From: Thomas Tuegel Date: Thu, 22 Jun 2017 17:28:15 -0500 Subject: kdeFrameworks, plasma5: fix setup hooks The setup hooks for many kdeFrameworks and plasma5 packages were erroneously running before $outputDev was set. This lead to .dev outputs being propagated into the user environment. --- pkgs/desktops/plasma-5/default.nix | 31 ++++++++++++++++++++----------- 1 file changed, 20 insertions(+), 11 deletions(-) (limited to 'pkgs/desktops/plasma-5/default.nix') diff --git a/pkgs/desktops/plasma-5/default.nix b/pkgs/desktops/plasma-5/default.nix index e101d4e14c5..a592a623510 100644 --- a/pkgs/desktops/plasma-5/default.nix +++ b/pkgs/desktops/plasma-5/default.nix @@ -43,17 +43,26 @@ let propagate = out: let setupHook = { writeScript }: - writeScript "setup-hook.sh" '' - # Propagate $${out} output - propagatedUserEnvPkgs+=" @${out}@" - - # Propagate $dev so that this setup hook is propagated - # But only if there is a separate $dev output - if [ "$outputDev" != out ]; then - if [ -n "$crossConfig" ]; then - propagatedBuildInputs+=" @dev@" - else - propagatedNativeBuildInputs+=" @dev@" + writeScript "setup-hook" '' + if [ "$hookName" != postHook ]; then + postHooks+=("source @dev@/nix-support/setup-hook") + else + # Propagate $${out} output + propagatedUserEnvPkgs="$propagatedUserEnvPkgs @${out}@" + + if [ -z "$outputDev" ]; then + echo "error: \$outputDev is unset!" >&2 + exit 1 + fi + + # Propagate $dev so that this setup hook is propagated + # But only if there is a separate $dev output + if [ "$outputDev" != out ]; then + if [ -n "$crossConfig" ]; then + propagatedBuildInputs="$propagatedBuildInputs @dev@" + else + propagatedNativeBuildInputs="$propagatedNativeBuildInputs @dev@" + fi fi fi ''; -- cgit 1.4.1