From decad1fc7da71db1d1b080a5ad248adcf8128a23 Mon Sep 17 00:00:00 2001
From: Bjørn Forsman <bjorn.forsman@gmail.com>
Date: Mon, 2 Sep 2013 22:13:01 +0200
Subject: nixpkgs-lint: add check for meta.platforms attribute

---
 maintainers/scripts/nixpkgs-lint.pl | 8 ++++++++
 1 file changed, 8 insertions(+)

(limited to 'maintainers/scripts')

diff --git a/maintainers/scripts/nixpkgs-lint.pl b/maintainers/scripts/nixpkgs-lint.pl
index baf2cbf8ba7..d74f5c740f5 100755
--- a/maintainers/scripts/nixpkgs-lint.pl
+++ b/maintainers/scripts/nixpkgs-lint.pl
@@ -44,6 +44,7 @@ my $info = XMLin($xml, KeyAttr => { 'item' => '+attrPath', 'meta' => 'name' }, F
 print "=== Package meta information ===\n\n";
 my $nrBadNames = 0;
 my $nrMissingMaintainers = 0;
+my $nrMissingPlatforms = 0;
 my $nrMissingDescriptions = 0;
 my $nrBadDescriptions = 0;
 my $nrMissingLicenses = 0;
@@ -77,6 +78,12 @@ foreach my $attr (sort keys %{$info->{item}}) {
         $nrMissingMaintainers++;
     }
 
+    # Check the platforms.
+    if (!defined $pkg->{meta}->{platforms}) {
+        print "$attr: Lacks a platform\n";
+        $nrMissingPlatforms++;
+    }
+
     # Package names should not be capitalised.
     if ($pkgName =~ /^[A-Z]/) {
         print "$attr: package name ‘$pkgName’ should not be capitalised\n";
@@ -159,6 +166,7 @@ print "=== Bottom line ===\n";
 print "Number of packages: ", scalar(keys %{$info->{item}}), "\n";
 print "Number of bad names: $nrBadNames\n";
 print "Number of missing maintainers: $nrMissingMaintainers\n";
+print "Number of missing platforms: $nrMissingPlatforms\n";
 print "Number of missing licenses: $nrMissingLicenses\n";
 print "Number of missing descriptions: $nrMissingDescriptions\n";
 print "Number of bad descriptions: $nrBadDescriptions\n";
-- 
cgit 1.4.1