From 726597c1a7d8bae7db3c065b2de6cfb148210452 Mon Sep 17 00:00:00 2001 From: Sergei Trofimovich Date: Mon, 30 Jan 2023 22:19:21 +0000 Subject: binutils: re-enable plugins support for wasi target binutils plugins API does not depend on target. It depends only on host. Tested the change to still be able to compile `firefox` which uses wasi target and pulls in llvm with binutils plugin support. --- pkgs/development/tools/misc/binutils/default.nix | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkgs/development/tools/misc/binutils/default.nix b/pkgs/development/tools/misc/binutils/default.nix index 1028422869e..b352410e213 100644 --- a/pkgs/development/tools/misc/binutils/default.nix +++ b/pkgs/development/tools/misc/binutils/default.nix @@ -243,8 +243,10 @@ stdenv.mkDerivation (finalAttrs: { inherit targetPrefix; hasGold = enableGold; isGNU = true; - # Having --enable-plugins is not enough, system has to support dlopen() - hasPluginAPI = enableGold && !stdenv.isDarwin && !stdenv.targetPlatform.isWasi; + # Having --enable-plugins is not enough, system has to support + # dlopen() or equivalent. See config/plugins.m4 and configure.ac + # (around PLUGINS) for cases that support or not support plugins. + hasPluginAPI = enableGold && !stdenv.isDarwin; }; meta = with lib; { -- cgit 1.4.1