summary refs log tree commit diff
path: root/pkgs
diff options
context:
space:
mode:
authorRobert Hensing <roberth@users.noreply.github.com>2021-11-19 22:48:38 +0100
committerGitHub <noreply@github.com>2021-11-19 22:48:38 +0100
commit2441a7992dfcddd2eb2a08f296a1b58b6c0b0ca7 (patch)
treebf8215875dcfe39ff705a8870789b8e636bbcbe9 /pkgs
parent34ce7c679be192f56f5394e2b641cdf602eff3d8 (diff)
parent6f70a225f4ca707d4f226e84df2a5ed622b87792 (diff)
downloadnixpkgs-2441a7992dfcddd2eb2a08f296a1b58b6c0b0ca7.tar
nixpkgs-2441a7992dfcddd2eb2a08f296a1b58b6c0b0ca7.tar.gz
nixpkgs-2441a7992dfcddd2eb2a08f296a1b58b6c0b0ca7.tar.bz2
nixpkgs-2441a7992dfcddd2eb2a08f296a1b58b6c0b0ca7.tar.lz
nixpkgs-2441a7992dfcddd2eb2a08f296a1b58b6c0b0ca7.tar.xz
nixpkgs-2441a7992dfcddd2eb2a08f296a1b58b6c0b0ca7.tar.zst
nixpkgs-2441a7992dfcddd2eb2a08f296a1b58b6c0b0ca7.zip
Merge pull request #146610 from l0b0/fix-keen4-shellcheck-lints
keen4: Fix ShellCheck lints
Diffstat (limited to 'pkgs')
-rw-r--r--pkgs/games/keen4/builder.sh21
1 files changed, 13 insertions, 8 deletions
diff --git a/pkgs/games/keen4/builder.sh b/pkgs/games/keen4/builder.sh
index b5864b8392f..f39edc78999 100644
--- a/pkgs/games/keen4/builder.sh
+++ b/pkgs/games/keen4/builder.sh
@@ -1,10 +1,15 @@
-source $stdenv/setup
+#!/usr/bin/env bash
 
-mkdir -p $out/share/keen4
-unzip -j $dist -d $out/share/keen4
+set -o nounset
 
-mkdir -p $out/bin
-cat > $out/bin/keen4 <<EOF
+# shellcheck source=/dev/null
+source "${stdenv}/setup"
+
+mkdir -p "${out}/share/keen4"
+unzip -j "$dist" -d "${out}/share/keen4"
+
+mkdir -p "${out}/bin"
+cat > "${out}/bin/keen4" <<EOF
 #! $SHELL -e
 if test -z "\$HOME"; then
     echo "HOME directory not set"
@@ -17,9 +22,9 @@ fi
 mkdir -p \$HOME/.keen4
 cd \$HOME/.keen4
 
-ln -sf $out/share/keen4/* .
+ln -sf "${out}/share/keen4/"* .
 
-$dosbox/bin/dosbox ./KEEN4E.EXE -fullscreen -exit || true
+"${dosbox}/bin/dosbox" ./KEEN4E.EXE -fullscreen -exit || true
 
 # Cleanup the symlinks.
 for i in *; do
@@ -28,4 +33,4 @@ for i in *; do
     fi
 done
 EOF
-chmod +x $out/bin/keen4
+chmod +x "${out}/bin/keen4"