diff options
| author | Eric Kow <eric.kow@gmail.com> | 2013-11-02 14:10:23 +0000 |
|---|---|---|
| committer | Eric Kow <eric.kow@gmail.com> | 2013-11-08 09:36:42 +0000 |
| commit | 29b2aec2338b6375c12d89f63a530ebc5e6406b2 (patch) | |
| tree | 9142fb20266d02ae176c7b4656c4affddac194d9 /pkgs/tools/networking/wget | |
| parent | 0aedd883e83a9b5731091fd9598327b8bbfe27f6 (diff) | |
| download | nixpkgs-29b2aec2338b6375c12d89f63a530ebc5e6406b2.tar nixpkgs-29b2aec2338b6375c12d89f63a530ebc5e6406b2.tar.gz nixpkgs-29b2aec2338b6375c12d89f63a530ebc5e6406b2.tar.bz2 nixpkgs-29b2aec2338b6375c12d89f63a530ebc5e6406b2.tar.lz nixpkgs-29b2aec2338b6375c12d89f63a530ebc5e6406b2.tar.xz nixpkgs-29b2aec2338b6375c12d89f63a530ebc5e6406b2.tar.zst nixpkgs-29b2aec2338b6375c12d89f63a530ebc5e6406b2.zip | |
wget darwin: disable Test-iri-disabled.px
This test fails on MacOS X. The failure has something to do with
the tests expecting filesystems to accept/store filenames as
bytes. On the HFS+ filesystem, however, filenames are Unicode
characters (Normalisation Form D).
This wget ticket appears to be relevant
http://savannah.gnu.org/bugs/index.php?27541
The maintainer does not seem to think that this test
failure represents a problem in practice:
http://article.gmane.org/gmane.comp.web.wget.general/8988
But this patch should be revisited/removed if this aspect of wget is
ever addressed in the future.
NB: I'm also a bit concerned/confused that none of the tests mentioned
in that message seem to fail, so I'm not 100% sure if this is the
relevant issue.
Diffstat (limited to 'pkgs/tools/networking/wget')
| -rw-r--r-- | pkgs/tools/networking/wget/default.nix | 2 | ||||
| -rw-r--r-- | pkgs/tools/networking/wget/iri-test.patch | 12 |
2 files changed, 14 insertions, 0 deletions
diff --git a/pkgs/tools/networking/wget/default.nix b/pkgs/tools/networking/wget/default.nix index 3e3b74dfe90..5ae85adbec7 100644 --- a/pkgs/tools/networking/wget/default.nix +++ b/pkgs/tools/networking/wget/default.nix @@ -8,6 +8,8 @@ stdenv.mkDerivation rec { sha256 = "0yqllj3nv9p3vqbdm6j4nvpjcwf1y19rq8sd966nrbd2qvvxfq8p"; }; + patches = stdenv.lib.optional stdenv.isDarwin ./iri-test.patch; + preConfigure = stdenv.lib.optionalString doCheck '' for i in "doc/texi2pod.pl" "tests/run-px" "util/rmold.pl" do diff --git a/pkgs/tools/networking/wget/iri-test.patch b/pkgs/tools/networking/wget/iri-test.patch new file mode 100644 index 00000000000..c1f798ce372 --- /dev/null +++ b/pkgs/tools/networking/wget/iri-test.patch @@ -0,0 +1,12 @@ +diff -r --unified a/wget-1.14/tests/run-px b/wget-1.14/tests/run-px +--- a/tests/run-px 2012-06-16 11:58:11.000000000 +0100 ++++ b/tests/run-px 2013-11-02 14:06:14.000000000 +0000 +@@ -48,7 +48,7 @@ + 'Test-idn-robots-utf8.px', + 'Test-iri.px', + 'Test-iri-percent.px', +- 'Test-iri-disabled.px', ++ #'Test-iri-disabled.px', + 'Test-iri-forced-remote.px', + 'Test-iri-list.px', + 'Test-k.px', |