summary refs log tree commit diff
path: root/nixos
diff options
context:
space:
mode:
authorFélix Baylac-Jacqué <felix@alternativebit.fr>2022-03-16 10:40:25 +0100
committerFélix Baylac-Jacqué <felix@alternativebit.fr>2022-03-17 15:22:14 +0100
commite7f6370701a3e65082e67cd0f9696bcd32c2e9ec (patch)
treeed5af4df79f646f8b64b8271e8a591f459b8bfaa /nixos
parent71d9048f72e4ec7afffbcd562f14d53714110522 (diff)
downloadnixpkgs-e7f6370701a3e65082e67cd0f9696bcd32c2e9ec.tar
nixpkgs-e7f6370701a3e65082e67cd0f9696bcd32c2e9ec.tar.gz
nixpkgs-e7f6370701a3e65082e67cd0f9696bcd32c2e9ec.tar.bz2
nixpkgs-e7f6370701a3e65082e67cd0f9696bcd32c2e9ec.tar.lz
nixpkgs-e7f6370701a3e65082e67cd0f9696bcd32c2e9ec.tar.xz
nixpkgs-e7f6370701a3e65082e67cd0f9696bcd32c2e9ec.tar.zst
nixpkgs-e7f6370701a3e65082e67cd0f9696bcd32c2e9ec.zip
nixosTests.pleroma: fix test, remove toot patch
It was originally impossible to login in toot without having an
interactive shell. I opened https://github.com/ihabunek/toot/pull/180
upstream to fix that and fetch this patch for this test.

The author decided to fix the issue using a slightly different
approach at https://github.com/ihabunek/toot/commit/a3eb5dca24e3efa8f16ebcdc4b7d635dc9af03b7

Because of this upstream fix, our custom patch does not apply anymore.
Using that stdin-based login upstream feature.
Diffstat (limited to 'nixos')
-rw-r--r--nixos/tests/pleroma.nix20
1 files changed, 2 insertions, 18 deletions
diff --git a/nixos/tests/pleroma.nix b/nixos/tests/pleroma.nix
index bf3623fce38..90a9a251104 100644
--- a/nixos/tests/pleroma.nix
+++ b/nixos/tests/pleroma.nix
@@ -32,8 +32,7 @@ import ./make-test-python.nix ({ pkgs, ... }:
     # system one. Overriding this pretty bad default behaviour.
     export REQUESTS_CA_BUNDLE=/etc/ssl/certs/ca-certificates.crt
 
-    export TOOT_LOGIN_CLI_PASSWORD="jamy-password"
-    toot login_cli -i "pleroma.nixos.test" -e "jamy@nixos.test"
+    echo "jamy-password" | toot login_cli -i "pleroma.nixos.test" -e "jamy@nixos.test"
     echo "Login OK"
 
     # Send a toot then verify it's part of the public timeline
@@ -168,21 +167,6 @@ import ./make-test-python.nix ({ pkgs, ... }:
     cp key.pem cert.pem $out
   '';
 
-  /* Toot is preventing users from feeding login_cli a password non
-     interactively. While it makes sense most of the times, it's
-     preventing us to login in this non-interactive test. This patch
-     introduce a TOOT_LOGIN_CLI_PASSWORD env variable allowing us to
-     provide a password to toot login_cli
-
-     If https://github.com/ihabunek/toot/pull/180 gets merged at some
-     point, feel free to remove this patch. */
-  custom-toot = pkgs.toot.overrideAttrs(old:{
-    patches = [ (pkgs.fetchpatch {
-      url = "https://github.com/NinjaTrappeur/toot/commit/b4a4c30f41c0cb7e336714c2c4af9bc9bfa0c9f2.patch";
-      sha256 = "sha256-0xxNwjR/fStLjjUUhwzCCfrghRVts+fc+fvVJqVcaFg=";
-    }) ];
-  });
-
   hosts = nodes: ''
     ${nodes.pleroma.config.networking.primaryIPAddress} pleroma.nixos.test
     ${nodes.client.config.networking.primaryIPAddress} client.nixos.test
@@ -194,7 +178,7 @@ import ./make-test-python.nix ({ pkgs, ... }:
       security.pki.certificateFiles = [ "${tls-cert}/cert.pem" ];
       networking.extraHosts = hosts nodes;
       environment.systemPackages = with pkgs; [
-        custom-toot
+        toot
         send-toot
       ];
     };