diff options
author | Samuel Dionne-Riel <samuel@dionne-riel.com> | 2019-01-19 14:20:15 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-01-19 14:20:15 -0500 |
commit | 50555a6d35b5a8b0794bb1fb295f9c0af7e0956e (patch) | |
tree | c36376de2871800fbe9bbd71dee14dc147d9707c /nixos | |
parent | 3fa77297b593bdcbb74250021a0130319384288c (diff) | |
parent | 3aab228d09f356c2aa170b5d581a9bde1c90db06 (diff) | |
download | nixpkgs-50555a6d35b5a8b0794bb1fb295f9c0af7e0956e.tar nixpkgs-50555a6d35b5a8b0794bb1fb295f9c0af7e0956e.tar.gz nixpkgs-50555a6d35b5a8b0794bb1fb295f9c0af7e0956e.tar.bz2 nixpkgs-50555a6d35b5a8b0794bb1fb295f9c0af7e0956e.tar.lz nixpkgs-50555a6d35b5a8b0794bb1fb295f9c0af7e0956e.tar.xz nixpkgs-50555a6d35b5a8b0794bb1fb295f9c0af7e0956e.tar.zst nixpkgs-50555a6d35b5a8b0794bb1fb295f9c0af7e0956e.zip |
Merge pull request #54330 from samueldr/fix/disable-tests-shell-access
Revert "Add ssh backdoor to VM tests infrastructure."
Diffstat (limited to 'nixos')
-rw-r--r-- | nixos/doc/manual/development/debugging-nixos-tests.xml | 37 | ||||
-rw-r--r-- | nixos/doc/manual/development/nixos-tests.xml | 1 | ||||
-rw-r--r-- | nixos/lib/test-driver/Machine.pm | 6 | ||||
-rw-r--r-- | nixos/modules/testing/test-instrumentation.nix | 3 |
4 files changed, 3 insertions, 44 deletions
diff --git a/nixos/doc/manual/development/debugging-nixos-tests.xml b/nixos/doc/manual/development/debugging-nixos-tests.xml deleted file mode 100644 index 30e58e1e355..00000000000 --- a/nixos/doc/manual/development/debugging-nixos-tests.xml +++ /dev/null @@ -1,37 +0,0 @@ -<section xmlns="http://docbook.org/ns/docbook" - xmlns:xlink="http://www.w3.org/1999/xlink" - xmlns:xi="http://www.w3.org/2001/XInclude" - version="5.0" - xml:id="sec-debugging-nixos-tests"> - <title>Debugging NixOS tests</title> - - <para> - Tests may fail and infrastructure offers access to inspect machine state. - </para> - - <para> - To prevent test from stopping and cleaning up, insert a sleep command: - </para> - -<programlisting> -$machine->succeed("sleep 84000"); -</programlisting> - - <para> - As soon as machine starts run as root: - </para> - -<programlisting> -nix-shell -p socat --run "socat STDIO,raw,echo=0,escape=0x11 UNIX:/tmp/nix-build-vm-test-run-*.drv-0/vm-state-machine/backdoor" -</programlisting> - - <para> - You may need to find the correct path, replacing <literal>/tmp</literal>, - <literal>*</literal> or <literal>machine</literal>. - </para> - - <para> - Press "enter" to open up console and login as "root". After you're done, - press "ctrl-q" to exit the console. - </para> -</section> diff --git a/nixos/doc/manual/development/nixos-tests.xml b/nixos/doc/manual/development/nixos-tests.xml index d068887200a..2695082e386 100644 --- a/nixos/doc/manual/development/nixos-tests.xml +++ b/nixos/doc/manual/development/nixos-tests.xml @@ -16,5 +16,4 @@ xlink:href="https://github.com/NixOS/nixpkgs/tree/master/nixos/tests">nixos/test <xi:include href="writing-nixos-tests.xml" /> <xi:include href="running-nixos-tests.xml" /> <xi:include href="running-nixos-tests-interactively.xml" /> - <xi:include href="debugging-nixos-tests.xml" /> </chapter> diff --git a/nixos/lib/test-driver/Machine.pm b/nixos/lib/test-driver/Machine.pm index c95bc548e04..006da889671 100644 --- a/nixos/lib/test-driver/Machine.pm +++ b/nixos/lib/test-driver/Machine.pm @@ -156,10 +156,8 @@ sub start { $ENV{USE_TMPDIR} = 1; $ENV{QEMU_OPTS} = ($self->{allowReboot} ? "" : "-no-reboot ") . - "-monitor unix:./monitor " . - "-chardev socket,id=shell,path=./shell -device virtio-serial -device virtconsole,chardev=shell " . - # socket backdoor, see "Debugging NixOS tests" section in NixOS manual - "-chardev socket,id=backdoor,path=./backdoor,server,nowait -device virtio-serial -device virtconsole,chardev=backdoor " . + "-monitor unix:./monitor -chardev socket,id=shell,path=./shell " . + "-device virtio-serial -device virtconsole,chardev=shell " . "-device virtio-rng-pci " . ($showGraphics ? "-serial stdio" : "-nographic") . " " . ($ENV{QEMU_OPTS} || ""); chdir $self->{stateDir} or die; diff --git a/nixos/modules/testing/test-instrumentation.nix b/nixos/modules/testing/test-instrumentation.nix index aa0db4afd97..ed4cfa7805e 100644 --- a/nixos/modules/testing/test-instrumentation.nix +++ b/nixos/modules/testing/test-instrumentation.nix @@ -55,8 +55,7 @@ with import ../../lib/qemu-flags.nix { inherit pkgs; }; systemd.services."serial-getty@hvc0".enable = false; # Only use a serial console, no TTY. - # hvc1: socket backdoor, see "Debugging NixOS tests" section in NixOS manual - virtualisation.qemu.consoles = [ "hvc1" qemuSerialDevice ]; + virtualisation.qemu.consoles = [ qemuSerialDevice ]; boot.initrd.preDeviceCommands = '' |