summary refs log tree commit diff
path: root/nixos/modules/services/networking
diff options
context:
space:
mode:
authorLuflosi <luflosi@luflosi.de>2022-01-25 14:02:58 +0100
committerLuflosi <luflosi@luflosi.de>2022-01-31 23:21:40 +0100
commitfd6d59f2edf79c9cff79d91b4c4cb62822f28bc0 (patch)
tree8d7b8928f8ab2a246d2bb9e03a12d011d4163578 /nixos/modules/services/networking
parentddc93d61c0dd1418aeddff7686da1d2ba0bc5db5 (diff)
downloadnixpkgs-fd6d59f2edf79c9cff79d91b4c4cb62822f28bc0.tar
nixpkgs-fd6d59f2edf79c9cff79d91b4c4cb62822f28bc0.tar.gz
nixpkgs-fd6d59f2edf79c9cff79d91b4c4cb62822f28bc0.tar.bz2
nixpkgs-fd6d59f2edf79c9cff79d91b4c4cb62822f28bc0.tar.lz
nixpkgs-fd6d59f2edf79c9cff79d91b4c4cb62822f28bc0.tar.xz
nixpkgs-fd6d59f2edf79c9cff79d91b4c4cb62822f28bc0.tar.zst
nixpkgs-fd6d59f2edf79c9cff79d91b4c4cb62822f28bc0.zip
nixos/i2pd: get rid of unnecessary shell script
I think calling i2pd directly in `ExecStart` is much nicer than having an extra shell script for no reason. It's also easier to see what's going on when looking at the generated systemd unit file.
Diffstat (limited to 'nixos/modules/services/networking')
-rw-r--r--nixos/modules/services/networking/i2pd.nix16
1 files changed, 7 insertions, 9 deletions
diff --git a/nixos/modules/services/networking/i2pd.nix b/nixos/modules/services/networking/i2pd.nix
index e1a31a0c2ee..34fda57b23d 100644
--- a/nixos/modules/services/networking/i2pd.nix
+++ b/nixos/modules/services/networking/i2pd.nix
@@ -222,14 +222,12 @@ let
         in concatStringsSep "\n" inTunOpts))];
     in pkgs.writeText "i2pd-tunnels.conf" opts;
 
-  i2pdSh = pkgs.writeScriptBin "i2pd" ''
-    #!/bin/sh
-    exec ${cfg.package}/bin/i2pd \
-      ${if cfg.address == null then "" else "--host="+cfg.address} \
-      --service \
-      --conf=${i2pdConf} \
-      --tunconf=${tunnelConf}
-  '';
+  i2pdFlags = concatStringsSep " " (
+    optional (cfg.address != null) ("--host=" + cfg.address) ++ [
+    "--service"
+    ("--conf=" + i2pdConf)
+    ("--tunconf=" + tunnelConf)
+  ]);
 
 in
 
@@ -686,7 +684,7 @@ in
         User = "i2pd";
         WorkingDirectory = homeDir;
         Restart = "on-abort";
-        ExecStart = "${i2pdSh}/bin/i2pd";
+        ExecStart = "${cfg.package}/bin/i2pd ${i2pdFlags}";
       };
     };
   };