summary refs log tree commit diff
path: root/nixos/modules/services/networking/smokeping.nix
diff options
context:
space:
mode:
authorNiklas Hambüchen <mail@nh2.me>2019-01-11 01:47:10 +0100
committerKerstin <kerstin@erictapen.name>2021-11-01 23:20:40 +0100
commit123171b557eb9a8ea6a4d7910ffe785f8d280d24 (patch)
tree29c76112e3b2e28687ee340b181a2eb676604b9e /nixos/modules/services/networking/smokeping.nix
parent17e4387b38ad35e2ba4fb8101d3cf36ccc14232f (diff)
downloadnixpkgs-123171b557eb9a8ea6a4d7910ffe785f8d280d24.tar
nixpkgs-123171b557eb9a8ea6a4d7910ffe785f8d280d24.tar.gz
nixpkgs-123171b557eb9a8ea6a4d7910ffe785f8d280d24.tar.bz2
nixpkgs-123171b557eb9a8ea6a4d7910ffe785f8d280d24.tar.lz
nixpkgs-123171b557eb9a8ea6a4d7910ffe785f8d280d24.tar.xz
nixpkgs-123171b557eb9a8ea6a4d7910ffe785f8d280d24.tar.zst
nixpkgs-123171b557eb9a8ea6a4d7910ffe785f8d280d24.zip
nixos/smokeping: Remove partOf to ensure restarts work.
Details on https://github.com/NixOS/nixops/issues/1063#issuecomment-453253666.

`partOf` makes that if `smokeping.service` is stopped, `thttpd.service` will
be stopped as well.
(But not that `thttpd` will be started when `smokeping` is started).

Once `thttpd.service` is stopped that way, `Restart = always` will not apply.

When the smokeping config options are changed, NixOS's `switch-configuration.pl`
will stop `smokeping` (whit shuts down thttpd due to `partOf`), and then restart
smokeping; but this does not start thttpd.
As a result, thttpd will be off after changing the config, which isn't desired.

This commit fixes it by removing the `partOf`, which makes `Restart` work
as expected.
Diffstat (limited to 'nixos/modules/services/networking/smokeping.nix')
-rw-r--r--nixos/modules/services/networking/smokeping.nix1
1 files changed, 0 insertions, 1 deletions
diff --git a/nixos/modules/services/networking/smokeping.nix b/nixos/modules/services/networking/smokeping.nix
index 675da281c91..a94dd3cf38e 100644
--- a/nixos/modules/services/networking/smokeping.nix
+++ b/nixos/modules/services/networking/smokeping.nix
@@ -332,7 +332,6 @@ in
     systemd.services.thttpd = mkIf cfg.webService {
       wantedBy = [ "multi-user.target"];
       requires = [ "smokeping.service"];
-      partOf = [ "smokeping.service"];
       path = with pkgs; [ bash rrdtool smokeping thttpd ];
       serviceConfig = {
         Restart = "always";