summary refs log tree commit diff
path: root/nixos/modules/installer
diff options
context:
space:
mode:
authorSamuel Dionne-Riel <samuel@dionne-riel.com>2018-11-27 21:52:10 -0500
committerTuomas Tynkkynen <tuomas.tynkkynen@iki.fi>2018-11-29 01:50:30 +0200
commit1b6a4d3979f13f990617d32ee9ec99b1f02673ec (patch)
tree9e43769326162cee632f15d658f32aed50ba755e /nixos/modules/installer
parent2e5eb135aac300032edd82e4b7a49a17dc80ba4d (diff)
downloadnixpkgs-1b6a4d3979f13f990617d32ee9ec99b1f02673ec.tar
nixpkgs-1b6a4d3979f13f990617d32ee9ec99b1f02673ec.tar.gz
nixpkgs-1b6a4d3979f13f990617d32ee9ec99b1f02673ec.tar.bz2
nixpkgs-1b6a4d3979f13f990617d32ee9ec99b1f02673ec.tar.lz
nixpkgs-1b6a4d3979f13f990617d32ee9ec99b1f02673ec.tar.xz
nixpkgs-1b6a4d3979f13f990617d32ee9ec99b1f02673ec.tar.zst
nixpkgs-1b6a4d3979f13f990617d32ee9ec99b1f02673ec.zip
sd-image: Do not use batch operation for `mcopy`.
```
       b      Batch mode. Optimized for huge recursive copies, but less secure if a crash happens during the copy.
```

It seems the "less secure if a crash happens" does not need a crash to
happen.

With batch mode:

```
/[...]/.
  Start (0) does not point to parent (___)
```

For pretty much everything copied in.

Without batch mode, everything passes `fsck`.

See #51150
Diffstat (limited to 'nixos/modules/installer')
-rw-r--r--nixos/modules/installer/cd-dvd/sd-image.nix2
1 files changed, 1 insertions, 1 deletions
diff --git a/nixos/modules/installer/cd-dvd/sd-image.nix b/nixos/modules/installer/cd-dvd/sd-image.nix
index e3b1ce3b7c4..69746a8e979 100644
--- a/nixos/modules/installer/cd-dvd/sd-image.nix
+++ b/nixos/modules/installer/cd-dvd/sd-image.nix
@@ -134,7 +134,7 @@ in
         ${config.sdImage.populateBootCommands}
 
         # Copy the populated /boot into the SD image
-        (cd boot; mcopy -bpsvm -i ../bootpart.img ./* ::)
+        (cd boot; mcopy -psvm -i ../bootpart.img ./* ::)
         # Verify the FAT partition before copying it.
         fsck.vfat -vn bootpart.img
         dd conv=notrunc if=bootpart.img of=$img seek=$START count=$SECTORS