summary refs log tree commit diff
path: root/nixos/modules/installer/tools/nixos-generate-config.pl
diff options
context:
space:
mode:
authorVladimír Čunát <vcunat@gmail.com>2016-01-25 07:55:42 +0100
committerVladimír Čunát <vcunat@gmail.com>2016-01-25 07:57:53 +0100
commit3e1599f57bbc9a83222ba0cbd91e55f09ce48875 (patch)
tree0f5f701b5426c75bda03dfb3f3ec8c50e0c17f73 /nixos/modules/installer/tools/nixos-generate-config.pl
parentc473bea69a93c22ab3215156433a14f563626839 (diff)
downloadnixpkgs-3e1599f57bbc9a83222ba0cbd91e55f09ce48875.tar
nixpkgs-3e1599f57bbc9a83222ba0cbd91e55f09ce48875.tar.gz
nixpkgs-3e1599f57bbc9a83222ba0cbd91e55f09ce48875.tar.bz2
nixpkgs-3e1599f57bbc9a83222ba0cbd91e55f09ce48875.tar.lz
nixpkgs-3e1599f57bbc9a83222ba0cbd91e55f09ce48875.tar.xz
nixpkgs-3e1599f57bbc9a83222ba0cbd91e55f09ce48875.tar.zst
nixpkgs-3e1599f57bbc9a83222ba0cbd91e55f09ce48875.zip
nixos-generate-config: fix #12595: broadcom quoting
Diffstat (limited to 'nixos/modules/installer/tools/nixos-generate-config.pl')
-rw-r--r--nixos/modules/installer/tools/nixos-generate-config.pl17
1 files changed, 12 insertions, 5 deletions
diff --git a/nixos/modules/installer/tools/nixos-generate-config.pl b/nixos/modules/installer/tools/nixos-generate-config.pl
index c590c4cde3f..2284eba07a2 100644
--- a/nixos/modules/installer/tools/nixos-generate-config.pl
+++ b/nixos/modules/installer/tools/nixos-generate-config.pl
@@ -148,7 +148,7 @@ sub pciCheck {
          $device eq "0x4331" || $device eq "0x43a0" || $device eq "0x43b1"
         ) )
      {
-        push @modulePackages, "\${config.boot.kernelPackages.broadcom_sta}";
+        push @modulePackages, "config.boot.kernelPackages.broadcom_sta";
         push @kernelModules, "wl";
      }
 
@@ -422,13 +422,20 @@ EOF
 
 # Generate the hardware configuration file.
 
-sub toNixExpr {
+sub toNixStringList {
     my $res = "";
     foreach my $s (@_) {
         $res .= " \"$s\"";
     }
     return $res;
 }
+sub toNixList {
+    my $res = "";
+    foreach my $s (@_) {
+        $res .= " $s";
+    }
+    return $res;
+}
 
 sub multiLineList {
     my $indent = shift;
@@ -444,9 +451,9 @@ sub multiLineList {
     return $res;
 }
 
-my $initrdAvailableKernelModules = toNixExpr(uniq @initrdAvailableKernelModules);
-my $kernelModules = toNixExpr(uniq @kernelModules);
-my $modulePackages = toNixExpr(uniq @modulePackages);
+my $initrdAvailableKernelModules = toNixStringList(uniq @initrdAvailableKernelModules);
+my $kernelModules = toNixStringList(uniq @kernelModules);
+my $modulePackages = toNixList(uniq @modulePackages);
 
 my $fsAndSwap = "";
 if (!$noFilesystems) {