diff options
author | github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> | 2021-04-20 12:06:46 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-04-20 12:06:46 +0000 |
commit | 960439e00365c518526323c5a16effa66027198a (patch) | |
tree | d68bf8019be8304b8fc2e484ca1ea2b11f3d0b8b /doc | |
parent | e605a07cc01532f9632203fc98868a584320f15a (diff) | |
parent | 88bbec3a5ebf05b9a113bda5bbfd84da84b07c4b (diff) | |
download | nixpkgs-960439e00365c518526323c5a16effa66027198a.tar nixpkgs-960439e00365c518526323c5a16effa66027198a.tar.gz nixpkgs-960439e00365c518526323c5a16effa66027198a.tar.bz2 nixpkgs-960439e00365c518526323c5a16effa66027198a.tar.lz nixpkgs-960439e00365c518526323c5a16effa66027198a.tar.xz nixpkgs-960439e00365c518526323c5a16effa66027198a.tar.zst nixpkgs-960439e00365c518526323c5a16effa66027198a.zip |
Merge master into staging-next
Diffstat (limited to 'doc')
-rw-r--r-- | doc/contributing/reviewing-contributions.xml | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/doc/contributing/reviewing-contributions.xml b/doc/contributing/reviewing-contributions.xml index 991db77bc58..7f83834bd8e 100644 --- a/doc/contributing/reviewing-contributions.xml +++ b/doc/contributing/reviewing-contributions.xml @@ -170,60 +170,60 @@ </para> <para> - Reviewing process: + Review process: </para> <itemizedlist> <listitem> <para> - Ensure that the package versioning is fitting the guidelines. + Ensure that the package versioning fits the guidelines. </para> </listitem> <listitem> <para> - Ensure that the commit name is fitting the guidelines. + Ensure that the commit name fits the guidelines. </para> </listitem> <listitem> <para> - Ensure that the meta field contains correct information. + Ensure that the meta fields contain correct information. </para> <itemizedlist> <listitem> <para> - License must be checked to be fitting upstream license. + License must match the upstream license. </para> </listitem> <listitem> <para> - Platforms should be set or the package will not get binary substitutes. + Platforms should be set (or the package will not get binary substitutes). </para> </listitem> <listitem> <para> - A maintainer must be set. This can be the package submitter or a community member that accepts to take maintainership of the package. + Maintainers must be set. This can be the package submitter or a community member that accepts taking up maintainership of the package. </para> </listitem> </itemizedlist> </listitem> <listitem> <para> - Ensure that the code contains no typos. + Report detected typos. </para> </listitem> <listitem> <para> - Ensure the package source. + Ensure the package source: </para> <itemizedlist> <listitem> <para> - Mirrors urls should be used when available. + Uses mirror URLs when available. </para> </listitem> <listitem> <para> - The most appropriate function should be used (e.g. packages from GitHub should use <literal>fetchFromGitHub</literal>). + Uses the most appropriate functions (e.g. packages from GitHub should use <literal>fetchFromGitHub</literal>). </para> </listitem> </itemizedlist> |