summary refs log tree commit diff
path: root/doc/contributing
diff options
context:
space:
mode:
authorEvils <evils.devils@protonmail.com>2021-02-07 02:16:42 +0100
committerEvils <evils.devils@protonmail.com>2021-04-20 02:52:09 +0200
commit7b5850ee1b7d952aab3d6fac1f01f6764eff1b9a (patch)
tree0aa256342974068d2e04a2c1540c4989ddee17e4 /doc/contributing
parent0a5f5bab0e08e968ef25cff393312aa51a3512cf (diff)
downloadnixpkgs-7b5850ee1b7d952aab3d6fac1f01f6764eff1b9a.tar
nixpkgs-7b5850ee1b7d952aab3d6fac1f01f6764eff1b9a.tar.gz
nixpkgs-7b5850ee1b7d952aab3d6fac1f01f6764eff1b9a.tar.bz2
nixpkgs-7b5850ee1b7d952aab3d6fac1f01f6764eff1b9a.tar.lz
nixpkgs-7b5850ee1b7d952aab3d6fac1f01f6764eff1b9a.tar.xz
nixpkgs-7b5850ee1b7d952aab3d6fac1f01f6764eff1b9a.tar.zst
nixpkgs-7b5850ee1b7d952aab3d6fac1f01f6764eff1b9a.zip
docs: correct some english
Diffstat (limited to 'doc/contributing')
-rw-r--r--doc/contributing/reviewing-contributions.xml22
1 files changed, 11 insertions, 11 deletions
diff --git a/doc/contributing/reviewing-contributions.xml b/doc/contributing/reviewing-contributions.xml
index 991db77bc58..7f83834bd8e 100644
--- a/doc/contributing/reviewing-contributions.xml
+++ b/doc/contributing/reviewing-contributions.xml
@@ -170,60 +170,60 @@
   </para>
 
   <para>
-   Reviewing process:
+   Review process:
   </para>
 
   <itemizedlist>
    <listitem>
     <para>
-     Ensure that the package versioning is fitting the guidelines.
+     Ensure that the package versioning fits the guidelines.
     </para>
    </listitem>
    <listitem>
     <para>
-     Ensure that the commit name is fitting the guidelines.
+     Ensure that the commit name fits the guidelines.
     </para>
    </listitem>
    <listitem>
     <para>
-     Ensure that the meta field contains correct information.
+     Ensure that the meta fields contain correct information.
     </para>
     <itemizedlist>
      <listitem>
       <para>
-       License must be checked to be fitting upstream license.
+       License must match the upstream license.
       </para>
      </listitem>
      <listitem>
       <para>
-       Platforms should be set or the package will not get binary substitutes.
+       Platforms should be set (or the package will not get binary substitutes).
       </para>
      </listitem>
      <listitem>
       <para>
-       A maintainer must be set. This can be the package submitter or a community member that accepts to take maintainership of the package.
+       Maintainers must be set. This can be the package submitter or a community member that accepts taking up maintainership of the package.
       </para>
      </listitem>
     </itemizedlist>
    </listitem>
    <listitem>
     <para>
-     Ensure that the code contains no typos.
+     Report detected typos.
     </para>
    </listitem>
    <listitem>
     <para>
-     Ensure the package source.
+     Ensure the package source:
     </para>
     <itemizedlist>
      <listitem>
       <para>
-       Mirrors urls should be used when available.
+       Uses mirror URLs when available.
       </para>
      </listitem>
      <listitem>
       <para>
-       The most appropriate function should be used (e.g. packages from GitHub should use <literal>fetchFromGitHub</literal>).
+       Uses the most appropriate functions (e.g. packages from GitHub should use <literal>fetchFromGitHub</literal>).
       </para>
      </listitem>
     </itemizedlist>