summary refs log tree commit diff
path: root/doc/contributing/coding-conventions.chapter.md
diff options
context:
space:
mode:
authorRobert Hensing <robert@roberthensing.nl>2021-07-14 19:03:58 +0200
committerRobert Hensing <robert@roberthensing.nl>2021-07-14 19:03:58 +0200
commit840fd0a4f8d1d7cd32328b9d853b34165884fdfc (patch)
tree6dc0ad322b3c8dbeb45228ff40344788376220ac /doc/contributing/coding-conventions.chapter.md
parentb141a58ff28c1b14fea9292dbcfe2a5af2da923c (diff)
downloadnixpkgs-840fd0a4f8d1d7cd32328b9d853b34165884fdfc.tar
nixpkgs-840fd0a4f8d1d7cd32328b9d853b34165884fdfc.tar.gz
nixpkgs-840fd0a4f8d1d7cd32328b9d853b34165884fdfc.tar.bz2
nixpkgs-840fd0a4f8d1d7cd32328b9d853b34165884fdfc.tar.lz
nixpkgs-840fd0a4f8d1d7cd32328b9d853b34165884fdfc.tar.xz
nixpkgs-840fd0a4f8d1d7cd32328b9d853b34165884fdfc.tar.zst
nixpkgs-840fd0a4f8d1d7cd32328b9d853b34165884fdfc.zip
doc/coding-conventions: Increase passthru test timeout 3s -> 60s
3s is too small a margin for a loaded slow system to start a bloated
program.
This leads to problems when tests are written on decent dev hardware
but later run on build farms of potentially slower hardware,
particularly in the case of non x86.

The chance of needing the timeout is actually very small, so those
rare 57s are a reasonable price to pay for fewer timeouts on build
farms, each of which should be investigated and usually fixed by
increasing the timeout.
Diffstat (limited to 'doc/contributing/coding-conventions.chapter.md')
-rw-r--r--doc/contributing/coding-conventions.chapter.md2
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/contributing/coding-conventions.chapter.md b/doc/contributing/coding-conventions.chapter.md
index e42ba512b98..240260105c3 100644
--- a/doc/contributing/coding-conventions.chapter.md
+++ b/doc/contributing/coding-conventions.chapter.md
@@ -568,7 +568,7 @@ let
   inherit (phoronix-test-suite) pname version;
 in
 
-runCommand "${pname}-tests" { meta.timeout = 3; }
+runCommand "${pname}-tests" { meta.timeout = 60; }
   ''
     # automatic initial setup to prevent interactive questions
     ${phoronix-test-suite}/bin/phoronix-test-suite enterprise-setup >/dev/null