diff options
author | misuzu <bakalolka@gmail.com> | 2021-02-03 17:18:49 +0200 |
---|---|---|
committer | misuzu <bakalolka@gmail.com> | 2021-02-03 17:18:49 +0200 |
commit | bdc96d33511d95a783ead5533b0d866b0a251aab (patch) | |
tree | 189114d51a1c9bc060b0ca1a56ab25cfafe35fca | |
parent | fab6fcdceb2560a4ab943830a2b1632458c7a6ff (diff) | |
download | nixpkgs-bdc96d33511d95a783ead5533b0d866b0a251aab.tar nixpkgs-bdc96d33511d95a783ead5533b0d866b0a251aab.tar.gz nixpkgs-bdc96d33511d95a783ead5533b0d866b0a251aab.tar.bz2 nixpkgs-bdc96d33511d95a783ead5533b0d866b0a251aab.tar.lz nixpkgs-bdc96d33511d95a783ead5533b0d866b0a251aab.tar.xz nixpkgs-bdc96d33511d95a783ead5533b0d866b0a251aab.tar.zst nixpkgs-bdc96d33511d95a783ead5533b0d866b0a251aab.zip |
nixos/gitlab-runner: warn about possible secrets leak
-rw-r--r-- | nixos/modules/services/continuous-integration/gitlab-runner.nix | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/nixos/modules/services/continuous-integration/gitlab-runner.nix b/nixos/modules/services/continuous-integration/gitlab-runner.nix index 2c6d9530a6b..15c37c2bc76 100644 --- a/nixos/modules/services/continuous-integration/gitlab-runner.nix +++ b/nixos/modules/services/continuous-integration/gitlab-runner.nix @@ -339,6 +339,9 @@ in <literal>CI_SERVER_URL=<CI server URL></literal> <literal>REGISTRATION_TOKEN=<registration secret></literal> + + WARNING: make sure to use quoted absolute path, + or it is going to be copied to Nix Store. ''; }; registrationFlags = mkOption { @@ -523,7 +526,10 @@ in }; }; config = mkIf cfg.enable { - warnings = optional (cfg.configFile != null) "services.gitlab-runner.`configFile` is deprecated, please use services.gitlab-runner.`services`."; + warnings = (mapAttrsToList + (n: v: "services.gitlab-runner.services.${n}.`registrationConfigFile` points to a file in Nix Store. You should use quoted absolute path to prevent this.") + (filterAttrs (n: v: isStorePath v.registrationConfigFile) cfg.services)) + ++ optional (cfg.configFile != null) "services.gitlab-runner.`configFile` is deprecated, please use services.gitlab-runner.`services`."; environment.systemPackages = [ cfg.package ]; systemd.services.gitlab-runner = { description = "Gitlab Runner"; |