summary refs log tree commit diff
diff options
context:
space:
mode:
authorRobin Gloster <mail@glob.in>2021-05-22 09:26:47 -0500
committerGitHub <noreply@github.com>2021-05-22 09:26:47 -0500
commit2b5910ac631f755832381cdbdf7aa93f18d45d4e (patch)
tree50c46f127693d04cd6077766f1fd44520d2311ed
parentcc345ca4d9fea08a89ee5da5107b10c5d1db002c (diff)
parent8803c45998da886be243ca6c8e5cb07650c57026 (diff)
downloadnixpkgs-2b5910ac631f755832381cdbdf7aa93f18d45d4e.tar
nixpkgs-2b5910ac631f755832381cdbdf7aa93f18d45d4e.tar.gz
nixpkgs-2b5910ac631f755832381cdbdf7aa93f18d45d4e.tar.bz2
nixpkgs-2b5910ac631f755832381cdbdf7aa93f18d45d4e.tar.lz
nixpkgs-2b5910ac631f755832381cdbdf7aa93f18d45d4e.tar.xz
nixpkgs-2b5910ac631f755832381cdbdf7aa93f18d45d4e.tar.zst
nixpkgs-2b5910ac631f755832381cdbdf7aa93f18d45d4e.zip
Merge pull request #123802 from superherointj/package-virtmanager-bugfix
virt-manager: add tests
-rw-r--r--pkgs/applications/virtualization/virt-manager/default.nix18
1 files changed, 16 insertions, 2 deletions
diff --git a/pkgs/applications/virtualization/virt-manager/default.nix b/pkgs/applications/virtualization/virt-manager/default.nix
index f15a2e91496..4d74b5d6610 100644
--- a/pkgs/applications/virtualization/virt-manager/default.nix
+++ b/pkgs/applications/virtualization/virt-manager/default.nix
@@ -5,6 +5,7 @@
 , gtksourceview4, docutils
 , spiceSupport ? true, spice-gtk ? null
 , cpio, e2fsprogs, findutils, gzip
+, cdrtools
 }:
 
 with lib;
@@ -53,8 +54,21 @@ python3Packages.buildPythonApplication rec {
     gappsWrapperArgs+=(--prefix PATH : "${makeBinPath [ cpio e2fsprogs file findutils gzip ]}")
   '';
 
-  # Failed tests
-  doCheck = false;
+  checkInputs = with python3Packages; [ cpio cdrtools pytestCheckHook ];
+
+  disabledTestPaths = [
+    "tests/test_cli.py"
+    "tests/test_disk.py"
+    "tests/test_checkprops.py"
+  ]; # Error logs: https://gist.github.com/superherointj/fee040872beaafaaa19b8bf8f3ff0be5
+
+  preCheck = ''
+    export HOME=.
+  ''; # <- Required for "tests/test_urldetect.py".
+
+  postCheck = ''
+    $out/bin/virt-manager --version | grep -Fw ${version} > /dev/null
+  '';
 
   meta = with lib; {
     homepage = "http://virt-manager.org";