diff options
| author | Robert Hensing <roberth@users.noreply.github.com> | 2021-10-31 20:56:30 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-10-31 20:56:30 +0100 |
| commit | 93c54e06bc53e849f7206b122d71e6e8ef2206c9 (patch) | |
| tree | 84757effc069b99d251fccfeaa106fd46353354c /.github/PULL_REQUEST_TEMPLATE.md | |
| parent | 9545fade8bb37ed7d6d722ff7cc5f5156e48c7d4 (diff) | |
| download | nixpkgs-93c54e06bc53e849f7206b122d71e6e8ef2206c9.tar nixpkgs-93c54e06bc53e849f7206b122d71e6e8ef2206c9.tar.gz nixpkgs-93c54e06bc53e849f7206b122d71e6e8ef2206c9.tar.bz2 nixpkgs-93c54e06bc53e849f7206b122d71e6e8ef2206c9.tar.lz nixpkgs-93c54e06bc53e849f7206b122d71e6e8ef2206c9.tar.xz nixpkgs-93c54e06bc53e849f7206b122d71e6e8ef2206c9.tar.zst nixpkgs-93c54e06bc53e849f7206b122d71e6e8ef2206c9.zip | |
PULL_REQUEST_TEMPLATE.md: Elaborate on testing
We've recently seen VM tests being added that could have been simple package tests instead.
Diffstat (limited to '.github/PULL_REQUEST_TEMPLATE.md')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index bfc07096aa9..2a17c416073 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -21,7 +21,11 @@ Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing- - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) -- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) +- [ ] Tested, as applicable: + - [ ] [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) + - [ ] and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) + - [ ] or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) + - [ ] made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) |