summary refs log tree commit diff
path: root/.github/PULL_REQUEST_TEMPLATE.md
diff options
context:
space:
mode:
authorLas Safin <me@las.rs>2021-08-14 11:39:46 +0000
committerLas Safin <me@las.rs>2021-08-19 13:01:59 +0000
commit629f88f3af556743e26265a6accd9bde7262275c (patch)
treeb3e7e7c125ab1a96a2ad3184188096398128a8c2 /.github/PULL_REQUEST_TEMPLATE.md
parent57362d7d3ca6976c6c65fe4be85dc048152b7d3f (diff)
downloadnixpkgs-629f88f3af556743e26265a6accd9bde7262275c.tar
nixpkgs-629f88f3af556743e26265a6accd9bde7262275c.tar.gz
nixpkgs-629f88f3af556743e26265a6accd9bde7262275c.tar.bz2
nixpkgs-629f88f3af556743e26265a6accd9bde7262275c.tar.lz
nixpkgs-629f88f3af556743e26265a6accd9bde7262275c.tar.xz
nixpkgs-629f88f3af556743e26265a6accd9bde7262275c.tar.zst
nixpkgs-629f88f3af556743e26265a6accd9bde7262275c.zip
PULL_REQUEST_TEMPLATE.md: Improve platform checkboxes
1) Building with the sandbox enabled is the standard on Linux,
   so it is of little relevance with distribution they are using.
   Because of this, we now specify "Linux" instead of "NixOS",
   and the sandbox checkbox specifies "non-Linux".
2) aarch64 is a much more common platform, so we add two separate
   checkboxes for both aarch64-linux and aarch64-darwin.
3) The platform names now match what is actually used by Nix.
Diffstat (limited to '.github/PULL_REQUEST_TEMPLATE.md')
-rw-r--r--.github/PULL_REQUEST_TEMPLATE.md9
1 files changed, 5 insertions, 4 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 23d8a1b56a7..bfc07096aa9 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -15,11 +15,12 @@ Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-
 
 <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->
 
-- [ ] Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux)
 - Built on platform(s)
-   - [ ] NixOS
-   - [ ] macOS
-   - [ ] other Linux distributions
+  - [ ] x86_64-linux
+  - [ ] aarch64-linux
+  - [ ] x86_64-darwin
+  - [ ] aarch64-darwin
+- [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file))
 - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
 - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
 - [ ] Tested execution of all binary files (usually in `./result/bin/`)