summary refs log tree commit diff
path: root/.github/CODEOWNERS
diff options
context:
space:
mode:
authorJan Tojnar <jtojnar@gmail.com>2020-05-13 10:29:01 +0200
committerJan Tojnar <jtojnar@gmail.com>2020-05-13 12:12:18 +0200
commit3f3aeb7c85fb5b7e6b9e950aed3a36a0e65e8bde (patch)
tree3bc8dc6d08fc2f19ae48ff6f51bd0ecce3a14184 /.github/CODEOWNERS
parentfab2ee8c10c2d39310c8e3cdddde9fd118727063 (diff)
downloadnixpkgs-3f3aeb7c85fb5b7e6b9e950aed3a36a0e65e8bde.tar
nixpkgs-3f3aeb7c85fb5b7e6b9e950aed3a36a0e65e8bde.tar.gz
nixpkgs-3f3aeb7c85fb5b7e6b9e950aed3a36a0e65e8bde.tar.bz2
nixpkgs-3f3aeb7c85fb5b7e6b9e950aed3a36a0e65e8bde.tar.lz
nixpkgs-3f3aeb7c85fb5b7e6b9e950aed3a36a0e65e8bde.tar.xz
nixpkgs-3f3aeb7c85fb5b7e6b9e950aed3a36a0e65e8bde.tar.zst
nixpkgs-3f3aeb7c85fb5b7e6b9e950aed3a36a0e65e8bde.zip
maintainers/scripts/update.nix: refactor package collector
The `packagesWith` function expected an attrSet but `packagesWithUpdateScript`
could be passing it a derivation or a list when the attribute path
supplied by user through the `--argstr path` argument pointed to one.
It only worked because derivations are also attrSets and contain their
outputs as attributes, and did not work for lists at all.

Additionally, the improper handling would cause the `src` attribute
to be built in some rare cases (`mkYarnPackage` seems to trigger this).

Rewriting the `packagesWith` function to be inductive with a derivation
as a base case and attrSets and lists as inductive steps is much cleaner
and also fixes the unnecessary build.
Diffstat (limited to '.github/CODEOWNERS')
0 files changed, 0 insertions, 0 deletions