From ce8961d1fcba5724553ba21288fbec752b0c00bf Mon Sep 17 00:00:00 2001 From: Zach Reizner Date: Fri, 2 Feb 2018 15:07:15 -0800 Subject: allow non-dirty log memory regions from the plugin process Dirty logging is not necessary for every memory region, so the plugin process should be able to specific exactly which regions it would like dirty logging enabled for. TEST=cargo test --features plugin BUG=chromium:800626 Change-Id: I28b8285357e7de1c8c3a1392bdfdb4853ec5a654 Reviewed-on: https://chromium-review.googlesource.com/900294 Commit-Ready: Zach Reizner Tested-by: Zach Reizner Reviewed-by: Dylan Reid --- tests/plugin_adder.c | 2 +- tests/plugin_dirty_log.c | 2 +- tests/plugin_ioevent.c | 2 +- tests/plugin_irqfd.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) (limited to 'tests') diff --git a/tests/plugin_adder.c b/tests/plugin_adder.c index f6c514f..8728614 100644 --- a/tests/plugin_adder.c +++ b/tests/plugin_adder.c @@ -168,7 +168,7 @@ int main(int argc, char** argv) { memcpy(mem, code, sizeof(code)); struct crosvm_memory *mem_obj; - ret = crosvm_create_memory(crosvm, mem_fd, 0x1000, 0x1000, 0x1000, false, &mem_obj); + ret = crosvm_create_memory(crosvm, mem_fd, 0x1000, 0x1000, 0x1000, false, false, &mem_obj); if (ret) { fprintf(stderr, "failed to create memory in crosvm: %d\n", ret); return 1; diff --git a/tests/plugin_dirty_log.c b/tests/plugin_dirty_log.c index bc3db83..f266cdf 100644 --- a/tests/plugin_dirty_log.c +++ b/tests/plugin_dirty_log.c @@ -128,7 +128,7 @@ int main(int argc, char** argv) { memcpy(mem + LOAD_ADDRESS, code, sizeof(code)); struct crosvm_memory *mem_obj; - ret = crosvm_create_memory(crosvm, mem_fd, 0, mem_size, 0, false, &mem_obj); + ret = crosvm_create_memory(crosvm, mem_fd, 0, mem_size, 0, false, true, &mem_obj); if (ret) { fprintf(stderr, "failed to create memory in crosvm: %d\n", ret); return 1; diff --git a/tests/plugin_ioevent.c b/tests/plugin_ioevent.c index 3662810..2a0eca9 100644 --- a/tests/plugin_ioevent.c +++ b/tests/plugin_ioevent.c @@ -151,7 +151,7 @@ int main(int argc, char** argv) { memcpy(mem + LOAD_ADDRESS, code, sizeof(code)); struct crosvm_memory *mem_obj; - ret = crosvm_create_memory(crosvm, mem_fd, 0, mem_size, 0, false, &mem_obj); + ret = crosvm_create_memory(crosvm, mem_fd, 0, mem_size, 0, false, false, &mem_obj); if (ret) { fprintf(stderr, "failed to create memory in crosvm: %d\n", ret); return 1; diff --git a/tests/plugin_irqfd.c b/tests/plugin_irqfd.c index c6951df..490ebab 100644 --- a/tests/plugin_irqfd.c +++ b/tests/plugin_irqfd.c @@ -172,7 +172,7 @@ int main(int argc, char** argv) { memcpy(mem + LOAD_ADDRESS, g_code, sizeof(g_code)); struct crosvm_memory *mem_obj; - ret = crosvm_create_memory(crosvm, mem_fd, 0, mem_size, 0, false, &mem_obj); + ret = crosvm_create_memory(crosvm, mem_fd, 0, mem_size, 0, false, false, &mem_obj); if (ret) { fprintf(stderr, "failed to create memory in crosvm: %d\n", ret); return 1; -- cgit 1.4.1