From aecf9a4dee6c004bceabf268a5b36d24c3744ca6 Mon Sep 17 00:00:00 2001 From: David Tolnay Date: Thu, 11 Apr 2019 14:30:00 -0700 Subject: edition: Remove extern crate lines In Rust 2018 edition, `extern crate` is no longer required for importing from other crates. Instead of writing: extern crate dep; use dep::Thing; we write: use dep::Thing; In this approach, macros are imported individually from the declaring crate rather than through #[macro_use]. Before: #[macro_use] extern crate sys_util; After: use sys_util::{debug, error}; The only place that `extern crate` continues to be required is in importing the compiler's proc_macro API into a procedural macro crate. This will hopefully be fixed in a future Rust release. extern crate proc_macro; TEST=cargo check TEST=cargo check --all-features TEST=cargo check --target aarch64-unknown-linux-gnu TEST=local kokoro Change-Id: I0b43768c0d81f2a250b1959fb97ba35cbac56293 Reviewed-on: https://chromium-review.googlesource.com/1565302 Commit-Ready: David Tolnay Commit-Ready: ChromeOS CL Exonerator Bot Tested-by: David Tolnay Tested-by: kokoro Reviewed-by: David Tolnay --- kvm_sys/src/lib.rs | 3 --- kvm_sys/tests/sanity.rs | 3 --- 2 files changed, 6 deletions(-) (limited to 'kvm_sys') diff --git a/kvm_sys/src/lib.rs b/kvm_sys/src/lib.rs index bea9242..9000b79 100644 --- a/kvm_sys/src/lib.rs +++ b/kvm_sys/src/lib.rs @@ -6,9 +6,6 @@ #![allow(non_camel_case_types)] #![allow(non_snake_case)] -#[macro_use] -extern crate sys_util; - use sys_util::{ioctl_io_nr, ioctl_ior_nr, ioctl_iow_nr, ioctl_iowr_nr}; // Somehow this one gets missed by bindgen diff --git a/kvm_sys/tests/sanity.rs b/kvm_sys/tests/sanity.rs index 2dd1326..7669b44 100644 --- a/kvm_sys/tests/sanity.rs +++ b/kvm_sys/tests/sanity.rs @@ -2,9 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -extern crate kvm_sys; -extern crate libc; - use libc::{c_char, ioctl, open, O_RDWR}; use kvm_sys::*; -- cgit 1.4.1