From 8b274875fb59a69be573607c3b29c63e80568ccd Mon Sep 17 00:00:00 2001 From: David Tolnay Date: Fri, 12 Apr 2019 18:19:34 -0700 Subject: clippy: Resolve ptr_arg TEST=bin/clippy Change-Id: I2880852da218bcb96c56c49977ba9d86e3156f70 Reviewed-on: https://chromium-review.googlesource.com/1566738 Commit-Ready: David Tolnay Tested-by: David Tolnay Tested-by: kokoro Reviewed-by: Daniel Verkamp --- devices/src/virtio/virtio_pci_common_config.rs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'devices/src/virtio/virtio_pci_common_config.rs') diff --git a/devices/src/virtio/virtio_pci_common_config.rs b/devices/src/virtio/virtio_pci_common_config.rs index 2fef26e..7f7eaca 100644 --- a/devices/src/virtio/virtio_pci_common_config.rs +++ b/devices/src/virtio/virtio_pci_common_config.rs @@ -42,7 +42,7 @@ impl VirtioPciCommonConfig { &mut self, offset: u64, data: &mut [u8], - queues: &mut Vec, + queues: &mut [Queue], device: &mut dyn VirtioDevice, ) { match data.len() { @@ -70,7 +70,7 @@ impl VirtioPciCommonConfig { &mut self, offset: u64, data: &[u8], - queues: &mut Vec, + queues: &mut [Queue], device: &mut dyn VirtioDevice, ) { match data.len() { @@ -102,7 +102,7 @@ impl VirtioPciCommonConfig { } } - fn read_common_config_word(&self, offset: u64, queues: &Vec) -> u16 { + fn read_common_config_word(&self, offset: u64, queues: &[Queue]) -> u16 { match offset { 0x10 => 0, // TODO msi-x (crbug/854765): self.msix_config, 0x12 => queues.len() as u16, // num_queues @@ -120,7 +120,7 @@ impl VirtioPciCommonConfig { } } - fn write_common_config_word(&mut self, offset: u64, value: u16, queues: &mut Vec) { + fn write_common_config_word(&mut self, offset: u64, value: u16, queues: &mut [Queue]) { match offset { 0x10 => (), // TODO msi-x (crbug/854765): self.msix_config = value, 0x16 => self.queue_select = value, @@ -154,7 +154,7 @@ impl VirtioPciCommonConfig { &mut self, offset: u64, value: u32, - queues: &mut Vec, + queues: &mut [Queue], device: &mut dyn VirtioDevice, ) { fn hi(v: &mut GuestAddress, x: u32) { @@ -194,7 +194,7 @@ impl VirtioPciCommonConfig { 0 // Assume the guest has no reason to read write-only registers. } - fn write_common_config_qword(&mut self, offset: u64, value: u64, queues: &mut Vec) { + fn write_common_config_qword(&mut self, offset: u64, value: u64, queues: &mut [Queue]) { match offset { 0x20 => self.with_queue_mut(queues, |q| q.desc_table = GuestAddress(value)), 0x28 => self.with_queue_mut(queues, |q| q.avail_ring = GuestAddress(value)), @@ -205,14 +205,14 @@ impl VirtioPciCommonConfig { } } - fn with_queue(&self, queues: &Vec, f: F) -> Option + fn with_queue(&self, queues: &[Queue], f: F) -> Option where F: FnOnce(&Queue) -> U, { queues.get(self.queue_select as usize).map(f) } - fn with_queue_mut(&self, queues: &mut Vec, f: F) { + fn with_queue_mut(&self, queues: &mut [Queue], f: F) { if let Some(queue) = queues.get_mut(self.queue_select as usize) { f(queue); } -- cgit 1.4.1