summary refs log tree commit diff
path: root/x86_64/src
diff options
context:
space:
mode:
authorDavid Tolnay <dtolnay@chromium.org>2019-04-15 16:58:42 -0700
committerchrome-bot <chrome-bot@chromium.org>2019-04-18 19:51:01 -0700
commitdc4effa72b214bc3bd14ca2f7772ab1b728aef5b (patch)
tree61c308a8c165a6fbe65f947da4abd241a9dd265d /x86_64/src
parent64cd5eae5778b86f6e498a6fa1b1962693aa5a46 (diff)
downloadcrosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar
crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.gz
crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.bz2
crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.lz
crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.xz
crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.zst
crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.zip
clippy: Iterate without calling .iter()
See:
https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop
https://rust-lang.github.io/rust-clippy/master/index.html#explicit_into_iter_loop

Before:

    for element in slice.iter() {...}

After:

    for element in slice {...}

TEST=grep -r '\.iter() {'
TEST=grep -r '\.iter_mut() {'
TEST=grep -r '\.into_iter() {'
TEST=cargo check --all-features
TEST=local kokoro

Change-Id: I27f0df7cfa1064b2c8b162cba263513926a433a9
Reviewed-on: https://chromium-review.googlesource.com/1568525
Commit-Ready: David Tolnay <dtolnay@chromium.org>
Tested-by: David Tolnay <dtolnay@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Diffstat (limited to 'x86_64/src')
-rw-r--r--x86_64/src/cpuid.rs2
-rw-r--r--x86_64/src/mptable.rs2
2 files changed, 2 insertions, 2 deletions
diff --git a/x86_64/src/cpuid.rs b/x86_64/src/cpuid.rs
index 0a70a21..9f76550 100644
--- a/x86_64/src/cpuid.rs
+++ b/x86_64/src/cpuid.rs
@@ -53,7 +53,7 @@ const EDX_HTT_SHIFT: u32 = 28; // Hyper Threading Enabled.
 fn filter_cpuid(cpu_id: u64, cpu_count: u64, kvm_cpuid: &mut kvm::CpuId) -> Result<()> {
     let entries = kvm_cpuid.mut_entries_slice();
 
-    for entry in entries.iter_mut() {
+    for entry in entries {
         match entry.function {
             1 => {
                 // X86 hypervisor feature
diff --git a/x86_64/src/mptable.rs b/x86_64/src/mptable.rs
index 9277840..c2def2f 100644
--- a/x86_64/src/mptable.rs
+++ b/x86_64/src/mptable.rs
@@ -89,7 +89,7 @@ fn compute_checksum<T: Copy>(v: &T) -> u8 {
     // Safe because we are only reading the bytes within the size of the `T` reference `v`.
     let v_slice = unsafe { slice::from_raw_parts(v as *const T as *const u8, mem::size_of::<T>()) };
     let mut checksum: u8 = 0;
-    for i in v_slice.iter() {
+    for i in v_slice {
         checksum = checksum.wrapping_add(*i);
     }
     checksum