summary refs log tree commit diff
path: root/vm_control
diff options
context:
space:
mode:
authorDmitry Torokhov <dtor@chromium.org>2018-02-27 10:26:34 -0800
committerchrome-bot <chrome-bot@chromium.org>2018-02-27 20:17:07 -0800
commit8283248a6084020ce58daf05d096314520881fe0 (patch)
tree1a1616eb6da53a62763a0ebeb85df8afa4584e00 /vm_control
parent5ba068f9a4d86a8f976aca3e3f70ed16a3e1d4d8 (diff)
downloadcrosvm-8283248a6084020ce58daf05d096314520881fe0.tar
crosvm-8283248a6084020ce58daf05d096314520881fe0.tar.gz
crosvm-8283248a6084020ce58daf05d096314520881fe0.tar.bz2
crosvm-8283248a6084020ce58daf05d096314520881fe0.tar.lz
crosvm-8283248a6084020ce58daf05d096314520881fe0.tar.xz
crosvm-8283248a6084020ce58daf05d096314520881fe0.tar.zst
crosvm-8283248a6084020ce58daf05d096314520881fe0.zip
vm_control: do not use negative error coded for errno-based errors
Errors derived from sysem errors delivered via -1 return code/errno
should use positive error codes, not negative, in order for them to be
recognized by other components. I.e. we should use
errno::Error::new(EINVAL) and not -EINVAL.

TEST=cargo test --features plugin; cargo test -p kvm
BUG=None

Change-Id: I10d5992cb1e1750aa9b8a7269c4f574d7c753683
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/939866
Reviewed-by: Zach Reizner <zachr@chromium.org>
Diffstat (limited to 'vm_control')
-rw-r--r--vm_control/src/lib.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/vm_control/src/lib.rs b/vm_control/src/lib.rs
index dbcbece..0f39818 100644
--- a/vm_control/src/lib.rs
+++ b/vm_control/src/lib.rs
@@ -201,7 +201,7 @@ impl VmRequest {
                 let mmap = match MemoryMapping::from_fd(fd, size) {
                     Ok(v) => v,
                     Err(MmapError::SystemCallFailed(e)) => return VmResponse::Err(e),
-                    _ => return VmResponse::Err(SysError::new(-EINVAL)),
+                    _ => return VmResponse::Err(SysError::new(EINVAL)),
                 };
                 let pfn = *next_mem_pfn;
                 let slot =