diff options
| author | Zach Reizner <zachr@google.com> | 2019-05-22 17:26:53 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-05-23 07:35:18 -0700 |
| commit | 3e0fa36886a7fbed31709c7bcc90930356c0afae (patch) | |
| tree | 26be8e831f38a0b2b2979f4b1442dd907981efb0 /usb_util | |
| parent | 6b7373af988c457d44d7d82bd7ef3e70968f058c (diff) | |
| download | crosvm-3e0fa36886a7fbed31709c7bcc90930356c0afae.tar crosvm-3e0fa36886a7fbed31709c7bcc90930356c0afae.tar.gz crosvm-3e0fa36886a7fbed31709c7bcc90930356c0afae.tar.bz2 crosvm-3e0fa36886a7fbed31709c7bcc90930356c0afae.tar.lz crosvm-3e0fa36886a7fbed31709c7bcc90930356c0afae.tar.xz crosvm-3e0fa36886a7fbed31709c7bcc90930356c0afae.tar.zst crosvm-3e0fa36886a7fbed31709c7bcc90930356c0afae.zip | |
eliminate usage of uninitialized
uninitialized is deprecated and considered too dangerous to use for any of the use cases we were using. BUG=None TEST=passes smoke_test Change-Id: I5392cb8ec132f374d9b5590f72eb2cb329a82421 Reviewed-on: https://chromium-review.googlesource.com/1626795 Commit-Ready: Zach Reizner <zachr@chromium.org> Tested-by: Zach Reizner <zachr@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org>
Diffstat (limited to 'usb_util')
| -rw-r--r-- | usb_util/src/bindings.rs | 2 | ||||
| -rw-r--r-- | usb_util/src/libusb_device.rs | 3 |
2 files changed, 2 insertions, 3 deletions
diff --git a/usb_util/src/bindings.rs b/usb_util/src/bindings.rs index 90dcd5b..a3e7152 100644 --- a/usb_util/src/bindings.rs +++ b/usb_util/src/bindings.rs @@ -2152,7 +2152,7 @@ pub type libusb_iso_usage_type = u32; /// descriptor is documented in section 9.6.1 of the USB 3.0 specification. /// All multiple-byte fields are represented in host-endian format. #[repr(C)] -#[derive(Debug, Copy, Clone)] +#[derive(Default, Debug, Copy, Clone)] pub struct libusb_device_descriptor { /// Size of this descriptor (in bytes) pub bLength: u8, diff --git a/usb_util/src/libusb_device.rs b/usb_util/src/libusb_device.rs index 2a9ba86..e8f5120 100644 --- a/usb_util/src/libusb_device.rs +++ b/usb_util/src/libusb_device.rs @@ -50,8 +50,7 @@ impl LibUsbDevice { /// Get device descriptor of this device. pub fn get_device_descriptor(&self) -> Result<DeviceDescriptor> { // Safe because memory is initialized later. - let mut descriptor: bindings::libusb_device_descriptor = - unsafe { std::mem::uninitialized() }; + let mut descriptor: bindings::libusb_device_descriptor = Default::default(); // Safe because 'self.device' is valid and '&mut descriptor' is valid. try_libusb!(unsafe { bindings::libusb_get_device_descriptor(self.device, &mut descriptor) |