lint: Resolve the easier clippy lints

Hopefully the changes are self-explanatory and uncontroversial. This
eliminates much of the noise from `cargo clippy` and, for my purposes,
gives me a reasonable way to use it as a tool when writing and reviewing
code.

Here is the Clippy invocation I was using:

    cargo +nightly clippy -- -W clippy::correctness -A renamed_and_removed_lints -Aclippy::{blacklisted_name,borrowed_box,cast_lossless,cast_ptr_alignment,enum_variant_names,identity_op,if_same_then_else,mut_from_ref,needless_pass_by_value,new_without_default,new_without_default_derive,or_fun_call,ptr_arg,should_implement_trait,single_match,too_many_arguments,trivially_copy_pass_by_ref,unreadable_literal,unsafe_vector_initialization,useless_transmute}

TEST=cargo check --features wl-dmabuf,gpu,usb-emulation
TEST=boot linux

Change-Id: I55eb1b4a72beb2f762480e3333a921909314a0a2
Reviewed-on: https://chromium-review.googlesource.com/1356911
Commit-Ready: David Tolnay <dtolnay@chromium.org>
Tested-by: David Tolnay <dtolnay@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

1 files changed, 11 insertions, 15 deletions

diff --git a/sys_util/src/syslog.rs b/sys_util/src/syslog.rs
index c080041..be85d2b 100644
--- a/sys_util/src/syslog.rs
+++ b/sys_util/src/syslog.rs
@@ -45,7 +45,7 @@ use libc::{
 
 use getpid;
 
-const SYSLOG_PATH: &'static str = "/dev/log";
+const SYSLOG_PATH: &str = "/dev/log";
 
 /// The priority (i.e. severity) of a syslog message.
 ///
@@ -65,14 +65,14 @@ pub enum Priority {
 impl fmt::Display for Priority {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         match self {
-            &Priority::Emergency => write!(f, "EMERGENCY"),
-            &Priority::Alert => write!(f, "ALERT"),
-            &Priority::Critical => write!(f, "CRITICAL"),
-            &Priority::Error => write!(f, "ERROR"),
-            &Priority::Warning => write!(f, "WARNING"),
-            &Priority::Notice => write!(f, "NOTICE"),
-            &Priority::Info => write!(f, "INFO"),
-            &Priority::Debug => write!(f, "DEBUG"),
+            Priority::Emergency => write!(f, "EMERGENCY"),
+            Priority::Alert => write!(f, "ALERT"),
+            Priority::Critical => write!(f, "CRITICAL"),
+            Priority::Error => write!(f, "ERROR"),
+            Priority::Warning => write!(f, "WARNING"),
+            Priority::Notice => write!(f, "NOTICE"),
+            Priority::Info => write!(f, "INFO"),
+            Priority::Debug => write!(f, "DEBUG"),
         }
     }
 }
@@ -417,7 +417,7 @@ fn get_localtime() -> tm {
 /// # }
 /// ```
 pub fn log(pri: Priority, fac: Facility, file_name: &str, line: u32, args: fmt::Arguments) {
-    const MONTHS: [&'static str; 12] = [
+    const MONTHS: [&str; 12] = [
         "Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep", "Oct", "Nov", "Dec",
     ];
 
@@ -457,11 +457,7 @@ pub fn log(pri: Priority, fac: Facility, file_name: &str, line: u32, args: fmt::
     let (res, len) = {
         let mut buf_cursor = Cursor::new(&mut buf[..]);
         (
-            write!(
-                &mut buf_cursor,
-                "[{}:{}:{}] {}\n",
-                pri, file_name, line, args
-            ),
+            writeln!(&mut buf_cursor, "[{}:{}:{}] {}", pri, file_name, line, args),
             buf_cursor.position() as usize,
         )
     };